Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

scan: fixed code generator to use new obi standard #1970

Merged
merged 10 commits into from
Jun 21, 2020
Merged

scan: fixed code generator to use new obi standard #1970

merged 10 commits into from
Jun 21, 2020

Conversation

tansawit
Copy link
Contributor

Fixes: #1820, #1821

@render
Copy link

render bot commented Jun 14, 2020

Your Render PR Server URL is https://d3n-scan-pr-1970.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-brj06741do6hbosbqejg.

@render
Copy link

render bot commented Jun 14, 2020

Your Render PR Server at https://d3n-scan-pr-1970.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brj06741do6hbosbqejg.

@evilpeach evilpeach self-requested a review June 14, 2020 12:04
evilpeach
evilpeach suggested changes Jun 14, 2020
View reviewed changes
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generate code unit test?

@render
Copy link

render bot commented Jun 15, 2020

Your Render PR Server at https://d3n-scan-pr-1970.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brj06741do6hbosbqejg.

@render
Copy link

render bot commented Jun 15, 2020

Your Render PR Server at https://d3n-scan-pr-1970.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brj06741do6hbosbqejg.

1 similar comment
@render
Copy link

render bot commented Jun 15, 2020

Your Render PR Server at https://d3n-scan-pr-1970.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brj06741do6hbosbqejg.

@render
Copy link

render bot commented Jun 16, 2020

Your Render PR Server at https://d3n-scan-pr-1970.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brj06741do6hbosbqejg.

evilpeach
evilpeach approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tansawit tansawit requested a review from prin-r June 17, 2020 07:11
@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1970.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brj06741do6hbosbqejg.

@prin-r prin-r merged commit 1c8c8d9 into master Jun 21, 2020
@prin-r prin-r deleted the obi-go-solidity-code-generation branch June 21, 2020 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prin-r prin-r prin-r approved these changes

@evilpeach evilpeach evilpeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix code generator to generate decode result for go file
3 participants
@tansawit @prin-r @evilpeach