Add bandchain.js #1963

smiled0g · 2020-06-13T07:46:33Z

Note: the old bandchain.js branch got messed up due to an incorrect rebase. This PR is for the new branch with the same content.

render · 2020-06-13T07:46:35Z

Your Render PR Server URL is https://d3n-scan-pr-1963.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-13T07:49:38Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

evilpeach

Should we add the test to GitHub action?

render · 2020-06-14T11:55:30Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

smiled0g · 2020-06-14T16:47:03Z

Should we add the test to GitHub action?

Hmm.. I'm not entirely sure here. I guess we should, but in that case, we should also use mock server requests instead of the real requests to GuanYu devnet we're doing right now.

What do you think? @sorawit

sorawit · 2020-06-14T16:48:29Z

Yes. I think if we are to add it to github action, better be tests that don't rely on external API calls.

render · 2020-06-15T01:29:20Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-15T01:46:33Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-15T01:58:26Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-15T13:21:10Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-16T03:54:08Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-16T04:14:21Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-16T05:10:30Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-16T09:43:00Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-16T11:01:38Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-17T03:46:49Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-17T03:50:12Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

add new line

render · 2020-06-17T04:11:59Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-17T08:14:28Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-17T09:19:39Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-17T10:02:06Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

prin-r · 2020-06-17T10:04:44Z

helpers/bandchain.js/src/lib/BandChain.js

+    return this.getRequestID(broadcastResponse.txhash)
+  }
+
+  async getRequestID(txHash) {


I saw retryTimeout = 200 at "getRequestProof". So should we add it here as well ?

taobun

Nope

render · 2020-06-17T10:10:24Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

render · 2020-06-17T10:18:37Z

Your Render PR Server at https://d3n-scan-pr-1963.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-bri88mh8vr20oh4vgj60.

helpers/README.md

Add bandchain.js

1975655

smiled0g requested review from sorawit, tansawit, prin-r, evilpeach and taobun June 13, 2020 07:46

evilpeach reviewed Jun 14, 2020

View reviewed changes

Fix endpoint

b45082a

Fix getLastMatchingRequestResult interface

d83e81d

Add public, demo, biuld folder back for build purpose

2c22ae1

Change getLastMatchingRequestResult return result

8fd8017

smiled0g added 2 commits June 15, 2020 20:17

Include the response metadata in getLastMatchingRequestResult

f894e23

Update new version

ccdbf06

Add gas parameter

a27241f

Update version

011f881

Fix node.js incompatibility

79f5f15

Merge branch 'master' into new-bandchain.js

2144753

smiled0g requested a review from evilpeach June 17, 2020 03:18

Remove the builde process

4e46426

Fix readme

1e9fc88

Update babel.config.js

b7ce9c5

add new line

Remove unnecessary while(true) loops

1a52ab4

evilpeach approved these changes Jun 17, 2020

View reviewed changes

Fix condition check

143d7b8

Fix the getRequestID

fc7126d

prin-r approved these changes Jun 17, 2020

View reviewed changes

Merge branch 'master' into new-bandchain.js

e579796

prin-r reviewed Jun 17, 2020

View reviewed changes

Fix timeout

defdd5f

taobun suggested changes Jun 17, 2020

View reviewed changes

smiled0g added 2 commits June 17, 2020 17:10

Add docker ignore

f5498e8

Fix helpers README

ab749fd

smiled0g requested a review from taobun June 17, 2020 10:14

smiled0g added 2 commits June 17, 2020 17:14

Fix typo

a2d07d2

Fix typo

6c0ed36

taobun approved these changes Jun 17, 2020

View reviewed changes

helpers/README.md Outdated Show resolved Hide resolved

smiled0g merged commit f940f77 into master Jun 17, 2020

smiled0g deleted the new-bandchain.js branch June 17, 2020 10:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add bandchain.js #1963

Add bandchain.js #1963

smiled0g commented Jun 13, 2020 •

edited

Loading

render bot commented Jun 13, 2020

render bot commented Jun 13, 2020

evilpeach left a comment

render bot commented Jun 14, 2020

smiled0g commented Jun 14, 2020

sorawit commented Jun 14, 2020

render bot commented Jun 15, 2020

render bot commented Jun 15, 2020

render bot commented Jun 15, 2020

render bot commented Jun 15, 2020

render bot commented Jun 16, 2020

render bot commented Jun 16, 2020

render bot commented Jun 16, 2020

render bot commented Jun 16, 2020

render bot commented Jun 16, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

prin-r Jun 17, 2020

taobun left a comment

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

Add bandchain.js #1963

Add bandchain.js #1963

Conversation

smiled0g commented Jun 13, 2020 • edited Loading

render bot commented Jun 13, 2020

render bot commented Jun 13, 2020

evilpeach left a comment

Choose a reason for hiding this comment

render bot commented Jun 14, 2020

smiled0g commented Jun 14, 2020

sorawit commented Jun 14, 2020

render bot commented Jun 15, 2020

render bot commented Jun 15, 2020

render bot commented Jun 15, 2020

render bot commented Jun 15, 2020

render bot commented Jun 16, 2020

render bot commented Jun 16, 2020

render bot commented Jun 16, 2020

render bot commented Jun 16, 2020

render bot commented Jun 16, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

prin-r Jun 17, 2020

Choose a reason for hiding this comment

taobun left a comment

Choose a reason for hiding this comment

render bot commented Jun 17, 2020

render bot commented Jun 17, 2020

smiled0g commented Jun 13, 2020 •

edited

Loading