Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

chain: Reporter list of validator CLI and REST endpoint #1927

Merged
merged 20 commits into from
Jun 11, 2020
Merged

chain: Reporter list of validator CLI and REST endpoint #1927

merged 20 commits into from
Jun 11, 2020

Conversation

perimeko
Copy link
Contributor

fixed #1886

@perimeko perimeko requested review from sorawit, Benzbeeb and taobun June 10, 2020 09:00
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server URL is https://d3n-scan-pr-1927.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

1 similar comment
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

@perimeko perimeko force-pushed the reportor-list-rest branch from a7e218e to 04bf18f Compare June 10, 2020 09:27
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

sorawit
sorawit suggested changes Jun 10, 2020
View reviewed changes
Copy link
Member

@sorawit sorawit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add CLI command together with this PR.

chain/x/oracle/client/rest/rest.go Outdated Show resolved Hide resolved
chain/x/oracle/keeper/reporter.go Outdated Show resolved Hide resolved
chain/x/oracle/keeper/reporter.go Outdated Show resolved Hide resolved
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

@perimeko perimeko changed the title chain: Reporter list of validator REST endpoint chain: Reporter list of validator CLI and REST endpoint Jun 10, 2020
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

@perimeko perimeko requested a review from sorawit June 10, 2020 10:37
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

sorawit
sorawit suggested changes Jun 10, 2020
View reviewed changes
chain/x/oracle/keeper/reporter_test.go Outdated Show resolved Hide resolved
chain/x/oracle/types/querier.go Outdated Show resolved Hide resolved
chain/x/oracle/client/cli/query.go Outdated Show resolved Hide resolved
@perimeko perimeko requested a review from sorawit June 10, 2020 10:49
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

sorawit
sorawit suggested changes Jun 10, 2020
View reviewed changes
chain/x/oracle/client/cli/query.go Outdated Show resolved Hide resolved
chain/x/oracle/keeper/querier.go Outdated Show resolved Hide resolved
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

@perimeko perimeko requested a review from sorawit June 10, 2020 11:33
@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

taobun
taobun suggested changes Jun 11, 2020
View reviewed changes
chain/x/oracle/client/cli/query.go Outdated Show resolved Hide resolved
chain/x/oracle/keeper/reporter.go Outdated Show resolved Hide resolved
@perimeko perimeko force-pushed the reportor-list-rest branch from 3e7b57d to a2ed209 Compare June 11, 2020 03:50
@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

@perimeko perimeko requested a review from taobun June 11, 2020 04:12
@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

1 similar comment
@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

@perimeko perimeko force-pushed the reportor-list-rest branch from d3bf04b to ed6745f Compare June 11, 2020 08:22
@render
Copy link

render bot commented Jun 11, 2020

Your Render PR Server at https://d3n-scan-pr-1927.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brga27p8vr255kf443hg.

@taobun taobun merged commit bdd4712 into master Jun 11, 2020
@taobun taobun deleted the reportor-list-rest branch June 11, 2020 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sorawit sorawit sorawit approved these changes

@taobun taobun taobun approved these changes

@Benzbeeb Benzbeeb Awaiting requested review from Benzbeeb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reporter list of validator REST endpoint
3 participants
@perimeko @sorawit @taobun