Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Add request + response packet to request rest endpoint #1905

Merged
merged 9 commits into from
Jun 10, 2020
Merged

Add request + response packet to request rest endpoint #1905

merged 9 commits into from
Jun 10, 2020

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Jun 8, 2020

Fixed #1882

@Benzbeeb Benzbeeb requested review from sorawit, taobun and perimeko June 8, 2020 10:18
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server URL is https://d3n-scan-pr-1905.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-brf10o0951c9n7f8err0.

@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1905.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brf10o0951c9n7f8err0.

@Benzbeeb Benzbeeb force-pushed the 1882-get-result-endpoint branch from ed684af to f0f32c8 Compare June 9, 2020 04:45
@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1905.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brf10o0951c9n7f8err0.

sorawit
sorawit suggested changes Jun 9, 2020
View reviewed changes
chain/x/oracle/types/querier.go Outdated Show resolved Hide resolved
chain/x/oracle/keeper/querier.go Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb force-pushed the 1882-get-result-endpoint branch from f0f32c8 to 22167c7 Compare June 9, 2020 12:29
@Benzbeeb Benzbeeb requested a review from sorawit June 9, 2020 12:30
@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1905.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brf10o0951c9n7f8err0.

sorawit
sorawit suggested changes Jun 9, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1905.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brf10o0951c9n7f8err0.

@Benzbeeb Benzbeeb requested review from sorawit and taobun June 10, 2020 02:56
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1905.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brf10o0951c9n7f8err0.

taobun
taobun suggested changes Jun 10, 2020
View reviewed changes
chain/x/oracle/keeper/result.go Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb force-pushed the 1882-get-result-endpoint branch from f347039 to 26aa24d Compare June 10, 2020 03:23
@Benzbeeb Benzbeeb requested a review from taobun June 10, 2020 03:24
@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1905.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brf10o0951c9n7f8err0.

taobun
taobun suggested changes Jun 10, 2020
View reviewed changes
chain/x/oracle/keeper/querier.go Outdated
@@ -95,10 +95,19 @@ func queryRequestByID(ctx sdk.Context, path []string, k Keeper) ([]byte, error)
return nil, err
}
reports := k.GetReports(ctx, types.RequestID(id))
result, _ := k.GetResult(ctx, types.RequestID(id))

if !k.HasRequest(ctx, types.RequestID(id)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HasResult!!

@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1905.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brf10o0951c9n7f8err0.

@render
Copy link

render bot commented Jun 10, 2020

Your Render PR Server at https://d3n-scan-pr-1905.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brf10o0951c9n7f8err0.

@taobun taobun merged commit 7afe3bd into master Jun 10, 2020
@taobun taobun deleted the 1882-get-result-endpoint branch June 10, 2020 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sorawit sorawit sorawit approved these changes

@taobun taobun taobun approved these changes

@perimeko perimeko Awaiting requested review from perimeko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add request + response packet to request rest endpoint
3 participants
@Benzbeeb @sorawit @taobun