Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

scan: added helper tooltip #1904

Merged
merged 5 commits into from
Jun 9, 2020
Merged

scan: added helper tooltip #1904

merged 5 commits into from
Jun 9, 2020

Conversation

tansawit
Copy link
Contributor

@tansawit tansawit commented Jun 8, 2020 •
edited
Loading

Fixes: #1895

@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server URL is https://d3n-scan-pr-1904.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-brevv6ol1r1frc2hvme0.

@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1904.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevv6ol1r1frc2hvme0.

@tansawit tansawit requested review from evilpeach and prin-r June 8, 2020 09:17
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1904.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevv6ol1r1frc2hvme0.

1 similar comment
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1904.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevv6ol1r1frc2hvme0.

evilpeach
evilpeach suggested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a new component for Tooltip. Don't use Text.

@tansawit tansawit force-pushed the 1895-helper-tooltip branch from 7529029 to df53477 Compare June 9, 2020 08:49
@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1904.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevv6ol1r1frc2hvme0.

@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1904.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevv6ol1r1frc2hvme0.

@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1904.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevv6ol1r1frc2hvme0.

@prin-r prin-r merged commit ca0b8b7 into master Jun 9, 2020
@prin-r prin-r deleted the 1895-helper-tooltip branch June 9, 2020 10:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prin-r prin-r prin-r approved these changes

@evilpeach evilpeach evilpeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Help Tooltip
3 participants
@tansawit @prin-r @evilpeach