Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Store result in store instead of result hash #1903

Merged
merged 7 commits into from
Jun 9, 2020
Merged

Store result in store instead of result hash #1903

merged 7 commits into from
Jun 9, 2020

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Jun 8, 2020

Fixed #1881

@Benzbeeb Benzbeeb requested review from sorawit, taobun and perimeko June 8, 2020 08:57
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server URL is https://d3n-scan-pr-1903.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-brevqug951c9n7f884og.

@Benzbeeb Benzbeeb requested a review from prin-r June 8, 2020 09:00
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1903.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevqug951c9n7f884og.

sorawit
sorawit suggested changes Jun 8, 2020
View reviewed changes
bridges/evm/contracts/Bridge.sol Outdated Show resolved Hide resolved
chain/x/oracle/keeper/request.go Outdated Show resolved Hide resolved
chain/x/oracle/types/packets.go Show resolved Hide resolved
chain/x/oracle/types/packets.go Outdated Show resolved Hide resolved
chain/x/oracle/types/events.go Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb requested a review from sorawit June 8, 2020 09:14
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1903.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevqug951c9n7f884og.

1 similar comment
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1903.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevqug951c9n7f884og.

sorawit
sorawit suggested changes Jun 8, 2020
View reviewed changes
chain/x/oracle/types/packets_test.go Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb force-pushed the 1881-store-result-in-store branch from 3600c52 to aa57131 Compare June 8, 2020 13:28
@Benzbeeb Benzbeeb requested a review from sorawit June 8, 2020 13:29
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1903.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevqug951c9n7f884og.

@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1903.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevqug951c9n7f884og.

@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1903.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brevqug951c9n7f884og.

@Benzbeeb Benzbeeb merged commit 33d00d2 into master Jun 9, 2020
@Benzbeeb Benzbeeb deleted the 1881-store-result-in-store branch June 9, 2020 04:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sorawit sorawit sorawit approved these changes

@taobun taobun taobun approved these changes

@perimeko perimeko Awaiting requested review from perimeko

@prin-r prin-r Awaiting requested review from prin-r prin-r is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store result in store instead of result hash
3 participants
@Benzbeeb @sorawit @taobun