Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Rewrite execution environment #1892

Merged
merged 14 commits into from
Jun 19, 2020
Merged

Rewrite execution environment #1892

merged 14 commits into from
Jun 19, 2020

Conversation

taobun
Copy link
Member

@taobun taobun commented Jun 7, 2020

fixed #1954

@taobun taobun requested a review from sorawit June 7, 2020 11:19
@render
Copy link

render bot commented Jun 7, 2020

@render
Copy link

render bot commented Jun 7, 2020

Your Render PR Server at https://d3n-scan-pr-1892.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brecqkgl1r1frc2hje7g.

}

// AskExternalData implements Owasm ExecEnv interface.
func (env *PrepareEnv) AskExternalData(eid int64, did int64, data []byte) {
if int64(len(data)) > MaxRawRequestDataSize {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, should we panic here?

@taobun taobun force-pushed the revisit-exec-env branch from 6b48b7c to f3163a3 Compare June 16, 2020 17:08
@render
Copy link

render bot commented Jun 16, 2020

Your Render PR Server at https://d3n-scan-pr-1892.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brecqkgl1r1frc2hje7g.

@taobun taobun force-pushed the revisit-exec-env branch 2 times, most recently from 7bb44bf to 0224bbb Compare June 17, 2020 10:44
@taobun taobun requested a review from sorawit June 17, 2020 10:45
@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1892.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brecqkgl1r1frc2hje7g.

@taobun taobun force-pushed the revisit-exec-env branch from 0224bbb to 93f6af7 Compare June 17, 2020 13:43
@taobun taobun requested review from Benzbeeb and perimeko June 17, 2020 13:44
@render
Copy link

render bot commented Jun 17, 2020

Your Render PR Server at https://d3n-scan-pr-1892.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brecqkgl1r1frc2hje7g.

go-owasm/api/bindings.h Outdated Show resolved Hide resolved
go-owasm/api/env.go Outdated Show resolved Hide resolved
go-owasm/cbindgen.toml Outdated Show resolved Hide resolved
go-owasm/src/error.rs Outdated Show resolved Hide resolved
@taobun taobun force-pushed the revisit-exec-env branch from 93f6af7 to 040e06e Compare June 18, 2020 18:00
@taobun taobun requested a review from sorawit June 18, 2020 18:00
@taobun taobun force-pushed the revisit-exec-env branch from 040e06e to 7ff3c1a Compare June 19, 2020 10:07
@@ -18,6 +18,10 @@ impl Span {
}
}

pub fn create_writable(ptr: *mut u8, cap: usize) -> Span {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add unit tests?

@taobun taobun merged commit 952ae6e into master Jun 19, 2020
@taobun taobun deleted the revisit-exec-env branch June 19, 2020 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit exec env and define error from Chain to VM
4 participants