Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: binding obi.js #1888

Merged
merged 8 commits into from
Jun 9, 2020
Merged

Scan: binding obi.js #1888

merged 8 commits into from
Jun 9, 2020

Conversation

evilpeach
Copy link
Contributor

@evilpeach evilpeach commented Jun 6, 2020 •
edited
Loading

Fixes #1819

  • patch obi.js for publishing
  • binding obi.js
  • unit test
  • remove unused file

Addition

  • use Obi instead of Borsh
  • create extractField on Obi

@render
Copy link

render bot commented Jun 6, 2020

Your Render PR Server URL is https://d3n-scan-pr-1888.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-brdo53g951c9n7f7ck4g.

@render
Copy link

render bot commented Jun 6, 2020

Your Render PR Server at https://d3n-scan-pr-1888.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brdo53g951c9n7f7ck4g.

@evilpeach evilpeach changed the title Scan: 1819 binding obi.js Scan: binding obi.js Jun 7, 2020
@render
Copy link

render bot commented Jun 7, 2020

Your Render PR Server at https://d3n-scan-pr-1888.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brdo53g951c9n7f7ck4g.

@prin-r prin-r requested a review from smiled0g June 8, 2020 10:48
@evilpeach evilpeach force-pushed the 1819-binding-obi.js branch from cbcde69 to f34a537 Compare June 8, 2020 10:54
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1888.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brdo53g951c9n7f7ck4g.

@evilpeach evilpeach force-pushed the 1819-binding-obi.js branch from f34a537 to b2611a0 Compare June 8, 2020 13:34
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1888.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brdo53g951c9n7f7ck4g.

prin-r
prin-r previously approved these changes Jun 8, 2020
View reviewed changes
@render
Copy link

render bot commented Jun 8, 2020

Your Render PR Server at https://d3n-scan-pr-1888.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brdo53g951c9n7f7ck4g.

@evilpeach evilpeach requested a review from prin-r June 8, 2020 18:56
tansawit
tansawit suggested changes Jun 9, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
scan/src/bindings/Obi.re Outdated Show resolved Hide resolved
@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1888.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brdo53g951c9n7f7ck4g.

@prin-r prin-r requested a review from tansawit June 9, 2020 03:20
@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1888.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brdo53g951c9n7f7ck4g.

tansawit
tansawit previously approved these changes Jun 9, 2020
View reviewed changes
prin-r
prin-r previously approved these changes Jun 9, 2020
View reviewed changes
@evilpeach evilpeach dismissed stale reviews from prin-r and tansawit via 264f3fc June 9, 2020 05:54
@evilpeach evilpeach force-pushed the 1819-binding-obi.js branch from c712961 to 264f3fc Compare June 9, 2020 05:54
@evilpeach evilpeach requested review from tansawit and prin-r June 9, 2020 05:54
@render
Copy link

render bot commented Jun 9, 2020

Your Render PR Server at https://d3n-scan-pr-1888.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/static/srv-brdo53g951c9n7f7ck4g.

@prin-r prin-r merged commit ab93cc0 into master Jun 9, 2020
@prin-r prin-r deleted the 1819-binding-obi.js branch June 9, 2020 06:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tansawit tansawit tansawit approved these changes

@prin-r prin-r prin-r approved these changes

@sorawit sorawit Awaiting requested review from sorawit sorawit is a code owner

@taobun taobun Awaiting requested review from taobun taobun is a code owner

@smiled0g smiled0g Awaiting requested review from smiled0g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using obi.js instead of borsh.js to encode/decode struct of oracle script
4 participants
@evilpeach @smiled0g @tansawit @prin-r