Request keeper test 💯

chain/x/oracle/keeper/keeper.go

@@ -12,6 +12,7 @@ import (
 	paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
 	"github.com/cosmos/cosmos-sdk/x/staking"
 	"github.com/tendermint/tendermint/libs/log"
+	db "github.com/tendermint/tm-db"
 
 	"github.com/bandprotocol/bandchain/chain/pkg/filecache"
 	"github.com/bandprotocol/bandchain/chain/x/oracle/types"
@@ -171,3 +172,8 @@ func (k Keeper) AddFile(file []byte) string {
 func (k Keeper) GetFile(name string) []byte {
 	return k.fileCache.MustGetFile(name)
 }
+
+// GetIterator returns iterator overall oracle key.
+func (k Keeper) GetIterator(ctx sdk.Context) db.Iterator {
+	return sdk.KVStorePrefixIterator(ctx.KVStore(k.storeKey), []byte{})
+}

chain/x/oracle/keeper/request_test.go

@@ -135,3 +135,116 @@ func TestGetRandomValidatorsTooBigSize(t *testing.T) {
 	_, err := k.GetRandomValidators(ctx, 9999, int64(1))
 	require.Error(t, err)
 }
+
+func TestSaveResult(t *testing.T) {
+	_, ctx, k := createTestInput()
+	ctx = ctx.WithBlockTime(time.Unix(int64(1581589090), 0))
+
+	oracleScriptID := types.OracleScriptID(1)
+	calldata := []byte("CALLDATA")
+	vals := []sdk.ValAddress{Validator1.ValAddress, Validator2.ValAddress, Validator3.ValAddress}
+	minCount := uint64(1)
+	requestHeight := int64(999)
+	requestTime := int64(1581589700)
+	clientID := "beeb"
+	ibcInfo := types.NewIBCInfo("source_port", "source_channel")
+	rawRequestID := []types.ExternalID{1, 2, 3}
+	resolveStatus := types.ResolveStatus_Success
+	result := []byte("beeb")
+	id := k.AddRequest(ctx, types.NewRequest(
+		oracleScriptID, calldata, vals, minCount, requestHeight,
+		requestTime, clientID, &ibcInfo, rawRequestID))
+
+	packet := k.SaveResult(ctx, id, resolveStatus, result)
+	expectPacket := types.NewOracleResponsePacketData(clientID, id, uint64(0), requestTime, int64(1581589090), resolveStatus, result)
+	require.Equal(t, expectPacket, packet)
+}
+
+func TestProcessExpiredRequests(t *testing.T) {
+	_, ctx, k := createTestInput()
+	ctx = ctx.WithBlockHeight(5000) // set block height 5000
+	k.SetValidatorReportInfo(ctx, Validator1.ValAddress, types.NewValidatorReportInfo(Validator1.ValAddress, 1))
+
+	oracleScriptID := types.OracleScriptID(1)
+	calldata := []byte("CALLDATA")
+	vals := []sdk.ValAddress{Validator1.ValAddress}
+	minCount := uint64(2)
+	requestHeight := int64(4000) // request at height 4000
+	requestTime := int64(1581589700)
+	clientID := "beeb"
+	ibcInfo := types.NewIBCInfo("source_port", "source_channel")
+	rawRequestID := []types.ExternalID{1, 2}
+
+	request1 := types.NewRequest(
+		oracleScriptID, calldata, vals, minCount, requestHeight,
+		requestTime, clientID, &ibcInfo, rawRequestID)
+	request2 := types.NewRequest( // request height 1000000
+		oracleScriptID, calldata, vals, minCount, 1000000,
+		requestTime, clientID, &ibcInfo, rawRequestID)
+
+	id1 := k.AddRequest(ctx, request1)
+	id2 := k.AddRequest(ctx, request2)
+
+	rq1, err := k.GetRequest(ctx, id1)
+	require.NoError(t, err)
+	require.Equal(t, rq1, request1)
+	rq2, err := k.GetRequest(ctx, id2)
+	require.NoError(t, err)
+	require.Equal(t, rq2, request2)
+
+	reports1 := k.GetReports(ctx, id1)
+	reports2 := k.GetReports(ctx, id2)
+
+	require.Equal(t, []types.Report(nil), reports1)
+	require.Equal(t, []types.Report(nil), reports2)
+
+	rep := types.NewReport(
+		Validator1.ValAddress, []types.RawReport{
+			types.NewRawReport(1, 1, []byte("data1/1")),
+			types.NewRawReport(2, 0, []byte("data2/1")),
+		},
+	)
+
+	k.AddReport(ctx, id1, rep)
+	k.AddReport(ctx, id2, rep)
+
+	k.ProcessExpiredRequests(ctx)
+
+	reports1 = k.GetReports(ctx, id1)
+	reports2 = k.GetReports(ctx, id2)
+
+	info := k.GetValidatorReportInfoWithDefault(ctx, Validator1.ValAddress)
+	require.Equal(t, types.NewValidatorReportInfo(Validator1.ValAddress, 0), info)
+
+	require.Equal(t, []types.Report(nil), reports1) // report1 was removed because it already expired
+	require.Equal(t, []types.Report{rep}, reports2)
+
+	res, err := k.GetResult(ctx, id1) // Have result because request-id 1 is already expired
+	require.NotNil(t, res)
+	require.Nil(t, err)
+	res, err = k.GetResult(ctx, id2) // No result because request-id 2 isn't expired yet
+	require.Nil(t, res)
+	require.NotNil(t, err)
+
+	_, err = k.GetRequest(ctx, id1) // this request was removed because it already expired
+	require.Error(t, err)
+	rq2, err = k.GetRequest(ctx, id2)
+	require.NoError(t, err)
+	require.Equal(t, rq2, request2)
+}
+
+func TestProcessExpiredRequestsNoRequestInStore(t *testing.T) {
+	_, ctx, k := createTestInput()
+	before := 0
+	iterator := k.GetIterator(ctx)
+	for ; iterator.Valid(); iterator.Next() {
+		before++
+	}
+	k.ProcessExpiredRequests(ctx)
+	after := 0
+	iterator = k.GetIterator(ctx)
+	for ; iterator.Valid(); iterator.Next() {
+		after++
+	}
+	require.Equal(t, before, after)
+}