Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to group entity #581

Merged
merged 9 commits into from
Oct 27, 2024
Merged

Conversation

waddaboo
Copy link
Contributor

@waddaboo waddaboo commented Oct 17, 2024

Description

This PR adds a new field type to group entity to indicate if a group is an on-chain group or an off-chain group.

Related Issue

Does this introduce a breaking change?

  • Yes
  • No

Users must now include type when creating a group.

Example:

await groupService.createGroup(
   {
      name: "Group",
      description: "This is a description.",
      type: "off-chain",
      treeDepth: 16,
      fingerprintDuration: 3600
   }
)

Other information

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 11:37am
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 11:37am

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you! ✨

@vplasencia vplasencia merged commit 8f4285d into feat/on-chain-invites Oct 27, 2024
5 checks passed
@vplasencia
Copy link
Member

Hey @waddaboo! This file should also be updated to support the new property: https://github.com/bandada-infra/bandada/blob/main/database/seed.sql

Feel free to create a new PR for it.

Also, I just created a new branch called on-chain-invites. We can use that branch to merge all the changes related to the on-chain invite codes feature. Then, when the new feature is ready and working properly in that branch, we can merge it into dev to test in staging and then merge dev into main to have the feature in production.

@waddaboo waddaboo deleted the feat/group-types branch October 31, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants