Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#395: Implement off-chain group information download #549

Merged

Conversation

uooooo
Copy link
Contributor

@uooooo uooooo commented Sep 13, 2024

Description

Added a box and button to the off-chain group page (/groups/off-chain/[]) to allow downloading of group information.

Change apps/dashborad/src/pages/group.tsx

  • Added Download group box component
  • added handleDownload function
  • imported Spaser from chakura-ui

Does this introduce a breaking change?

  • Yes
  • [✔︎] No

Other information

スクリーンショット 2024-09-14 1 42 49 スクリーンショット 2024-09-14 1 43 20

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 1:21pm
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 1:21pm

@vplasencia
Copy link
Member

Hey @uooooo! Thank you very much 🙏

Could you run yarn prettier:write and push the changes and also yarn lint and fix the error?

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @uooooo great work! I left some comments. Thank you very much.

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @uooooo I just left one comment. I think the PR will be ready to merge after this comment is solved. Thank you very much.

Co-authored-by: Vivian Plasencia <[email protected]>
@uooooo
Copy link
Contributor Author

uooooo commented Sep 14, 2024

Hey @uooooo I just left one comment. I think the PR will be ready to merge after this comment is solved. Thank you very much.

Sorry for the inconvenience. I have made the changes. Could you please take a look?

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @uooooo! Great work! Thank you very much again 🙏

@vplasencia vplasencia changed the base branch from main to dev September 14, 2024 13:38
@vplasencia vplasencia merged commit 11a0a56 into bandada-infra:dev Sep 14, 2024
5 checks passed
Copy link

gitpoap-bot bot commented Sep 14, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Bandada Contributor:

GitPOAP: 2024 Bandada Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@vplasencia vplasencia linked an issue Sep 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download off-chain group information
2 participants