Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Polygon Amoy because Polygon Mumbai is deprecated #534

Closed
2 tasks done
vplasencia opened this issue Jun 27, 2024 · 16 comments
Closed
2 tasks done

Support Polygon Amoy because Polygon Mumbai is deprecated #534

vplasencia opened this issue Jun 27, 2024 · 16 comments
Assignees
Labels
bug 🐛 Something isn't working feature 🚀 This is enhancing something existing or creating something new refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Milestone

Comments

@vplasencia
Copy link
Member

vplasencia commented Jun 27, 2024

Description

Polygon Mumbai is deprecated, then Bandada should be updated to use Polygon Amoy instead.

Tasks

  • Update the code
  • Update the Bandada environment variable in the server
@vplasencia vplasencia added this to the 5. Rhea milestone Jun 27, 2024
@vplasencia vplasencia self-assigned this Jun 27, 2024
@vplasencia vplasencia moved this to 🗒 Tasks in Bandada Board Jun 27, 2024
@Agrim-Sharma174
Copy link

hey @vplasencia, I would like to work on this, please assign.

@vplasencia
Copy link
Member Author

Hey @Agrim-Sharma174, done. Thank you. Please let us know if you have questions.

@vplasencia vplasencia self-assigned this Aug 26, 2024
@ajayadsul
Copy link

Is this issue is available for proceeding further

@vplasencia vplasencia added bug 🐛 Something isn't working feature 🚀 This is enhancing something existing or creating something new refactoring ♻️ A code change that neither fixes a bug nor adds a feature labels Sep 16, 2024
@vplasencia
Copy link
Member Author

Hey @ajayadsul! Do you want me to assign the issue to you?

@AjayAdsule
Copy link
Contributor

@vplasencia please assign

@vplasencia
Copy link
Member Author

Hey @ajayadsul! Are you the owner of these two accounts: @ajayadsul and @AjayAdsule ?

@AjayAdsule
Copy link
Contributor

@vplasencia Yes ,i just mixed up my personal and work account apologize for that

@vplasencia
Copy link
Member Author

Got it. No worries. Feel free to start working on this issue and ask us any questions you may have.

Which account are you going to use to assign the issue to?

@AjayAdsule
Copy link
Contributor

please assign to @AjayAdsule

@vplasencia
Copy link
Member Author

Hey @AjayAdsule done.

@AjayAdsule
Copy link
Contributor

AjayAdsule commented Sep 18, 2024

image

image

@vplasencia require any changes ?
note i just comment out last two options for temporary

@vplasencia
Copy link
Member Author

It looks great!

I think that if you filter the word mumbai in the Bandada project you will find all the places that should be updated.

@AjayAdsule
Copy link
Contributor

AjayAdsule commented Sep 18, 2024

@vplasencia done i am creating pr

vplasencia added a commit that referenced this issue Sep 19, 2024
 replace deprecated polygon mumbai with polygon amoy  #534
@github-project-automation github-project-automation bot moved this from 🗒 Tasks to ✅ Done in Bandada Board Sep 19, 2024
@vplasencia vplasencia reopened this Sep 19, 2024
@vplasencia vplasencia moved this from ✅ Done to 👀 In review in Bandada Board Sep 19, 2024
@vplasencia vplasencia moved this from 👀 In review to 🏗 In progress in Bandada Board Sep 19, 2024
@vplasencia
Copy link
Member Author

Hey @AjayAdsule I just merged the PR. The server was also updated with the new environment variable. Thank you very much.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Bandada Board Sep 19, 2024
@vplasencia
Copy link
Member Author

Hey @Agrim-Sharma174! This issue is completed. If you're still interested in contributing, please feel free to ask for any open good first issue here: https://github.com/bandada-infra/bandada/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

I plan to add more good first issues soon. Thank you!

@AjayAdsule
Copy link
Contributor

@vplasencia thanks looking forward for more contribution on banada community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working feature 🚀 This is enhancing something existing or creating something new refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants