refactor: remove repeating code and update return url string

Co-authored-by: Vivian Plasencia <[email protected]>
bandada-infra · Jun 26, 2024 · 59f1137 · 59f1137
1 parent e3441c1
commit 59f1137
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/libs/api-sdk/src/groups.ts b/libs/api-sdk/src/groups.ts
@@ -388,9 +388,11 @@ export function joinCredentialGroup(
     providerName: string,
     redirectUri?: string
 ): string {
+    let resultUrl = `${baseUrl}/credentials?group=${groupId}&member=${commitment}&provider=${providerName}`
+
     if (redirectUri) {
-        return `${baseUrl}/credentials?group=${groupId}&member=${commitment}&provider=${providerName}&redirect_uri=${redirectUri}/groups?redirect=true`
+        resultUrl += `&redirect_uri=${redirectUri}?redirect=true`
     }
 
-    return `${baseUrl}/credentials?group=${groupId}&member=${commitment}&provider=${providerName}`
+    return resultUrl
 }