Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Ecto.Enum #8

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Conversation

dvic
Copy link
Collaborator

@dvic dvic commented Jan 26, 2021

Closes #7

@dvic
Copy link
Collaborator Author

dvic commented Jan 26, 2021

Note that this bumps Ecto to version 3.5 (because of Ecto.Enum)

@dvic
Copy link
Collaborator Author

dvic commented Feb 4, 2021

@bamorim did you have any chance to look at this? :)

@bamorim
Copy link
Owner

bamorim commented Feb 4, 2021

Sorry, I was on vacation after quitting my job hahaha.
I'll try to dedicate more effort for this lib. Thanks for the contribution. I'll test this and merge (looks good already).

@dvic
Copy link
Collaborator Author

dvic commented Feb 4, 2021

Hope you had a good time, no worries, take your time. Thanks for the library!

@bamorim
Copy link
Owner

bamorim commented Feb 5, 2021

@dvic I think my suggestion did not contained a blank line after the function definition. Sorry about that, my bad.

@bamorim bamorim merged commit 5ab8343 into bamorim:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for Ecto.Enum
2 participants