feat(profiler): prepare for flipper plugin publish #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Flipper plugin starts/stops the ATrace process, we need to ensure that when restarting it, atrace gets restarted ensureCppProfilerIsInstalled is responsible for that but is basing itself on the atraceProcess being null or not
Since getCpuClockTick and getRAMPageSize were previously called at the root, just importing the package and running commands would automatically install the cpp profiler (which is a task taking a few seconds) Several issues with that: - loading Flipper would load the Flipper plugin and try to install the c++ profiler which impacts Flipper load time a lot - since atrace would be started when loading the Flipper plugin, the buffer would already be filled with lots of data when actually starting measures - just less flexibility in general as we will see in the next commit
Flashlight Automated Report 🔦 |
Almouro
force-pushed
the
fix-for-flipper
branch
from
4fe2079 to
23beadd
Compare
Flashlight Automated Report 🔦 |
MaeIg
approved these changes
Oct 25, 2022
Almouro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.