Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix(carousel): support space and full-height #1586

Closed
1 task done
hirsch88 opened this issue Jan 29, 2025 · 2 comments · Fixed by #1587
Closed
1 task done

🐛 fix(carousel): support space and full-height #1586

hirsch88 opened this issue Jan 29, 2025 · 2 comments · Fixed by #1587
Assignees
@hirsch88
Labels
🐛 bug Something isn't working

Comments

@hirsch88
Copy link
Member

Current Behavior

<bal-carousel itemsPerView="auto" controls="small" class="w-full" full-height space="normal">
  <bal-carousel-item class="w-16rem" style="height: auto">
    <ng-container [ngTemplateOutlet]="buttonBasicTemplate() || null" />
  </bal-carousel-item>
  <bal-carousel-item class="w-16rem" style="height: auto">
  <ng-container [ngTemplateOutlet]="buttonPlusTemplate() || null" />
  </bal-carousel-item>
  <bal-carousel-item class="w-16rem" style="height: auto">
  <ng-container [ngTemplateOutlet]="buttonPremiumTemplate() || null" />
  </bal-carousel-item>
</bal-carousel>

Expected Behavior

A bug happened!

Steps to Reproduce

1

Version

latest

Browsers

No response

Device

No response

Code Reproduction URL

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hirsch88 hirsch88 added the 🐛 bug Something isn't working label Jan 29, 2025
@hirsch88 hirsch88 self-assigned this Jan 29, 2025
@hirsch88
Copy link
Member Author

/cib

@github-actions GitHub Actions
Copy link
Contributor

Branch fix/issue-1586 created!

github-actions bot added a commit that referenced this issue Jan 30, 2025
@github-actions
Create PR for #1586
3e58a06
@github-actions github-actions bot mentioned this issue Jan 30, 2025
Merged
hirsch88 added a commit that referenced this issue Jan 31, 2025
@github-actions @hirsch88
🐛 fix(carousel): support space and full-height (#1587)
5f3e38c 
* Create PR for #1586

* feat(carousel): add space and improve full-height

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirsch88 hirsch88

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fix(carousel): support space and full-height baloise/design-system
1 participant
@hirsch88