Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bal-date): Year and Month functionality off #1297

Closed
1 task done
GinaBiondo-aperto opened this issue Jan 21, 2024 · 2 comments · Fixed by #1298
Closed
1 task done

fix(bal-date): Year and Month functionality off #1297

GinaBiondo-aperto opened this issue Jan 21, 2024 · 2 comments · Fixed by #1298
Assignees
@hirsch88
Labels
🐛 bug Something isn't working

Comments

@GinaBiondo-aperto
Copy link
Collaborator

GinaBiondo-aperto commented Jan 21, 2024 •
edited
Loading

Current Behavior

  1. The first year and month are always highlighted
    image

  2. Disabled months can be selected
    image

  3. On first opening the user has to click twice to select a date

Expected Behavior

  1. Only current month and year should be highlighted
  2. Disabled months / years should not be selectable
  3. First click should trigger selection

Steps to Reproduce

Regular usage

Version

15.1.0

Browsers

Firefox, Chrome, Safari, Microsoft Edge

Device

No response

Code Reproduction URL

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@GinaBiondo-aperto GinaBiondo-aperto added the 🐛 bug Something isn't working label Jan 21, 2024
@hirsch88
Copy link
Member

/cib

@github-actions GitHub Actions
Copy link
Contributor

Branch fix/issue-1297 created!

github-actions bot added a commit that referenced this issue Jan 22, 2024
@github-actions
Create PR for #1297
b6714e4
@github-actions github-actions bot mentioned this issue Jan 22, 2024
Merged
mladenplaninicic pushed a commit that referenced this issue Jan 22, 2024
@github-actions @hirsch88
fix(bal-date): Year and Month functionality off (#1298)
5b133aa 
* Create PR for #1297

* fix(date): Disabled years or months in the selection list cannot be selected anymore

* fix(carousel): movement for large controls variant on mobile is optimized

* chore: format files

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirsch88 hirsch88

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bal-date): Year and Month functionality off baloise/design-system
2 participants
@hirsch88 @GinaBiondo-aperto