New detector for finding division by zero errors #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new detector `FindDivisionByZero` detects cases where the divisor is zero. The error message is `DZ_DIVISION_BY_ZERO`. Currently, only very straightforward cases are detected. However, if the new data-flow based `ValueRangeAnalysis` is enhanced then more advanced cases are automatically detected without the need of changing this detector.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new detector
FindDivisionByZerodetects cases where the divisor is zero. The error message isDZ_DIVISION_BY_ZERO.Currently, only very straightforward cases are detected. However, if the new data-flow based
ValueRangeAnalysisisenhanced then more advanced cases are automatically detected without the need of changing this detector.
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code