Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8.x] Remove types.bal generation from low level service #1586

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented Dec 18, 2023

Purpose

Reference PR: #1581
Related issue: https://github.com/wso2-enterprise/internal-support-ballerina/issues/528

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8ce672c) 79.74% compared to head (0495027) 79.84%.
Report is 11 commits behind head on 1.8.x.

Files Patch % Lines
...java/io/ballerina/openapi/core/GeneratorUtils.java 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              1.8.x    #1586      +/-   ##
============================================
+ Coverage     79.74%   79.84%   +0.09%     
- Complexity     1790     1807      +17     
============================================
  Files           124      124              
  Lines         10111    10154      +43     
  Branches       1680     1688       +8     
============================================
+ Hits           8063     8107      +44     
+ Misses         1461     1458       -3     
- Partials        587      589       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jan 2, 2024
@lnash94 lnash94 removed the Stale label Jan 3, 2024
@lnash94 lnash94 requested a review from TharmiganK January 3, 2024 03:20
Copy link
Contributor

@TharmiganK TharmiganK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnash94 lnash94 merged commit 7e6067a into ballerina-platform:1.8.x Jan 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants