-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable subscription tests #2112
Disable subscription tests #2112
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this, can't we disable the group altogether in the build script?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2112 +/- ##
============================================
- Coverage 84.84% 82.76% -2.08%
- Complexity 0 818 +818
============================================
Files 93 127 +34
Lines 6770 9679 +2909
Branches 1525 2031 +506
============================================
+ Hits 5744 8011 +2267
- Misses 946 1327 +381
- Partials 80 341 +261 ☔ View full report in Codecov by Sentry. |
Yes, we can do that. By doing in this manner, we can easily track the disabled tests within the repository, right? If not, we would need to update the build script. For other repositories, what we have done is disable the tests in the repository and create a separate issue to track them. |
My idea was to have a single place to disable the tests instead of going through a lot of lines of code. But I am okay with this too. |
Purpose
Temporarily disabling due to lang build intermittently hanging
Related issue: ballerina-platform/ballerina-library#7030
logs: https://github.com/ballerina-platform/ballerina-lang/actions/runs/12150965444/job/33892381168?pr=43606
Examples
Checklist
commons
package changes (if there are any, please update the GraphQL version in GraphQL tools and Ballerina dev tools)compiler
package changes (if there are any, please update the GraphQL version in Ballerina dev tools)