Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable subscription tests #2112

Merged

Conversation

MohamedSabthar
Copy link
Member

Purpose

Temporarily disabling due to lang build intermittently hanging
Related issue: ballerina-platform/ballerina-library#7030
logs: https://github.com/ballerina-platform/ballerina-lang/actions/runs/12150965444/job/33892381168?pr=43606

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • No commons package changes (if there are any, please update the GraphQL version in GraphQL tools and Ballerina dev tools)
  • No compiler package changes (if there are any, please update the GraphQL version in Ballerina dev tools)

Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, can't we disable the group altogether in the build script?

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.76%. Comparing base (149b571) to head (5997147).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2112      +/-   ##
============================================
- Coverage     84.84%   82.76%   -2.08%     
- Complexity        0      818     +818     
============================================
  Files            93      127      +34     
  Lines          6770     9679    +2909     
  Branches       1525     2031     +506     
============================================
+ Hits           5744     8011    +2267     
- Misses          946     1327     +381     
- Partials         80      341     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chiranSachintha
Copy link
Member

chiranSachintha commented Dec 4, 2024

Instead of this, can't we disable the group altogether in the build script?

Yes, we can do that. By doing in this manner, we can easily track the disabled tests within the repository, right? If not, we would need to update the build script. For other repositories, what we have done is disable the tests in the repository and create a separate issue to track them.

@ThisaruGuruge
Copy link
Member

Instead of this, can't we disable the group altogether in the build script?

Yes, we can do that. By doing in this manner, we can easily track the disabled tests within the repository, right? If not, we would need to update the build script. For other repositories, what we have done is disable the tests in the repository and create a separate issue to track them.

My idea was to have a single place to disable the tests instead of going through a lot of lines of code. But I am okay with this too.

@gimantha gimantha merged commit 9137f28 into ballerina-platform:master Dec 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants