Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the support for reading private/public keys from the content #558

Merged
merged 11 commits into from
May 30, 2024
Merged

Introduce the support for reading private/public keys from the content #558

merged 11 commits into from
May 30, 2024

Conversation

Bhashinee
Copy link
Member

@Bhashinee Bhashinee commented May 29, 2024 •
edited
Loading

Purpose

Implementation of the proposal ballerina-platform/ballerina-library#6517

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@Bhashinee Bhashinee changed the title Implement the support for reading private/public keys from the content Introduce the support for reading private/public keys from the content May 29, 2024
@Bhashinee Bhashinee marked this pull request as ready for review May 29, 2024 10:41
@Bhashinee Bhashinee force-pushed the versionUpdate branch 3 times, most recently from 73240e7 to dce796c Compare May 29, 2024 11:22
@ayeshLK
Copy link
Member

ayeshLK commented May 29, 2024

Shall we add the proposal to the package docs ?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ayeshLK
ayeshLK approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@ayeshLK ayeshLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bhashinee Bhashinee merged commit 88c10ae into ballerina-platform:master May 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilanSachi dilanSachi dilanSachi left review comments

@ayeshLK ayeshLK ayeshLK approved these changes

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

@MohamedSabthar MohamedSabthar Awaiting requested review from MohamedSabthar MohamedSabthar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bhashinee @ayeshLK @dilanSachi