Add DependencyManifest module to the PackageManifest dependency

[gayaldassanayake]

Purpose

When a package is found both in PackageManifest(Ballerina.toml) and the DependencyManifest(Dependencies.toml) we pick the dependency in the PackageManifest. This will go in the BlendedManifest. However, with that, we loose the information regarding the modules that are within the package since the user only specifies the org, name, version and repository (optional).

When this happens to a package that has a hierarchical name (eg - resource.kind), we cannot find a module that matches the the aforementioned dependency in the BlendedManifest because when trying to compare the module names, the entry in the BlendedManifest has an empty module list.

With this fix, when the same dependency is repeated in both Dependencies.toml and the Ballerina.toml, the module details are copied from the Dependencies.toml while other details are taken from the Ballerina.toml

Fixes https://github.com/wso2-enterprise/internal-support-ballerina/issues/811

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[gayaldassanayake]

This moduleNames(new DependencyManifest.Package(depInPkgManifest.name(), depInPkgManifest.org(), depInPkgManifest.version())) always returns an empty list of module names.

[sameerajayasoma]

Can we write a test using our resource test framework? Not sure whether this is supported in the resolution framework.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.56%. Comparing base (66f7b52) to head (2f3cada).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #43524   +/-   ##
=========================================
  Coverage     77.55%   77.56%           
- Complexity    58722    58736   +14     
=========================================
  Files          3447     3447           
  Lines        219658   219658           
  Branches      28915    28916    +1     
=========================================
+ Hits         170365   170382   +17     
+ Misses        39892    39886    -6     
+ Partials       9401     9390   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gayaldassanayake]

Can we write a test using our resource test framework? Not sure whether this is supported in the resolution framework.

Updated with a couple of tests.