Address the review comment

ballerina-platform · Feb 2, 2024 · ef0fc46 · ef0fc46
1 parent 025f800
commit ef0fc46
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/...ler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/MockDesugar.java b/...ler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/MockDesugar.java
@@ -116,12 +116,12 @@ public void generateMockFunctions(BLangPackage pkgNode) {
         Map<String, String> mockFunctionMap = pkgNode.getTestablePkg().getMockFunctionNamesMap();
 
         // Get the mock function type map from the pkgNode
-        Map<String, String> mockFunctionTypeMap = pkgNode.getTestablePkg().getMockFunctionTypeMap();
+        Map<String, Boolean> isLegacyMockingMap = pkgNode.getTestablePkg().getIsLegacyMockingMap();
 
         // Get the set of functions to generate
         Set<String> mockFunctionSet = mockFunctionMap.keySet();
         for (String function : mockFunctionSet) {
-            if ("LATEST".equals(mockFunctionTypeMap.get(function))) {
+            if (!isLegacyMockingMap.get(function)) {
                 pkgNode.getTestablePkg().functions.add(generateMockFunction(function));
             }
         }

diff --git a/...llerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/BLangTestablePackage.java b/...llerina-lang/src/main/java/org/wso2/ballerinalang/compiler/tree/BLangTestablePackage.java
@@ -30,7 +30,7 @@ public class BLangTestablePackage extends BLangPackage {
     //Map to maintain all the mock functions
     private Map<String, String> mockFunctionNamesMap = new HashMap<>();
 
-    private final Map<String, String> mockFunctionTypeMap = new HashMap<>();
+    private final Map<String, Boolean> isLegacyMockingMap = new HashMap<>();
     public Map<String, String> getMockFunctionNamesMap() {
         return mockFunctionNamesMap;
     }
@@ -49,11 +49,11 @@ public <T, R> R apply(BLangNodeTransformer<T, R> modifier, T props) {
         return modifier.transform(this, props);
     }
 
-    public Map<String, String> getMockFunctionTypeMap() {
-        return mockFunctionTypeMap;
+    public Map<String, Boolean> getIsLegacyMockingMap() {
+        return isLegacyMockingMap;
     }
 
-    public void addMockFunctionType(String id, String type) {
-        this.mockFunctionTypeMap.put(id, type);
+    public void addIsLegacyMockingMap(String id, Boolean isLegacy) {
+        this.isLegacyMockingMap.put(id, isLegacy);
     }
 }
diff --git a/...esterina-core/src/main/java/org/ballerinalang/testerina/core/MockAnnotationProcessor.java b/...esterina-core/src/main/java/org/ballerinalang/testerina/core/MockAnnotationProcessor.java
@@ -149,8 +149,8 @@ public void process(SimpleVariableNode simpleVariableNode, List<AnnotationAttach
                     bLangTestablePackage.addMockFunction(
                             functionToMockID + MOCK_FN_DELIMITER + annotationValues[1],
                             mockFnObjectName);
-                    bLangTestablePackage.addMockFunctionType(
-                            functionToMockID + MOCK_FN_DELIMITER + annotationValues[1], "LATEST");
+                    bLangTestablePackage.addIsLegacyMockingMap(
+                            functionToMockID + MOCK_FN_DELIMITER + annotationValues[1], false);
 
                     if (functionToMockID != null) {
                         // Adding `<className> # <functionToMock> --> <MockFnObjectName>` to registry
@@ -259,8 +259,8 @@ public void process(FunctionNode functionNode, List<AnnotationAttachmentNode> an
                             (BLangTestablePackage) ((BLangFunction) functionNode).parent; // parent -> BLangPackage
                     bLangTestablePackage.addMockFunction(functionToMockID + MOCK_LEGACY_DELIMITER + vals[1],
                             functionName);
-                    bLangTestablePackage.addMockFunctionType(functionToMockID + MOCK_LEGACY_DELIMITER + vals[1],
-                            "LEGACY");
+                    bLangTestablePackage.addIsLegacyMockingMap(functionToMockID + MOCK_LEGACY_DELIMITER + vals[1],
+                            true);
 
                     // Adding `<className> # <functionToMock> --> <MockFnObjectName>` to registry
                     String className = getQualifiedClassName(bLangTestablePackage,