Limit casting to only basic types

ballerina-platform · Jan 2, 2024 · ca4c44b · ca4c44b
1 parent 662a015
commit ca4c44b
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java b/compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
@@ -2468,7 +2468,7 @@ private void createSimpleVarDefStmt(BLangSimpleVariable simpleVariable, BLangBlo
 
     @Override
     public void visit(BLangAssignment assignNode) {
-        boolean isOptionalFieldAssignment = isOptionalFieldAssignment(assignNode);
+        boolean isOptionalFieldAssignment = isOptionalBasicTypeFieldAssignment(assignNode);
         assignNode.varRef = rewriteExpr(assignNode.varRef);
         assignNode.expr = rewriteExpr(assignNode.expr);
         BType castingType = assignNode.varRef.getBType();
@@ -2479,7 +2479,7 @@ public void visit(BLangAssignment assignNode) {
         result = assignNode;
     }
 
-    private boolean isOptionalFieldAssignment(BLangAssignment assignNode) {
+    private boolean isOptionalBasicTypeFieldAssignment(BLangAssignment assignNode) {
         if (assignNode.varRef.getKind() != NodeKind.FIELD_BASED_ACCESS_EXPR) {
             return false;
         }
@@ -2490,10 +2490,12 @@ private boolean isOptionalFieldAssignment(BLangAssignment assignNode) {
         }
         BRecordType recordType = (BRecordType) targetType;
         BField field = recordType.fields.get(fieldAccessNode.field.value);
-        if (field == null) {
+        if (field == null || (field.symbol.flags & Flags.OPTIONAL) != Flags.OPTIONAL) {
             return false;
         }
-        return (field.symbol.flags & Flags.OPTIONAL) == Flags.OPTIONAL;
+        BType fieldType = field.getType();
+        return fieldType.getKind() == TypeKind.BOOLEAN || fieldType.getKind() == TypeKind.FLOAT ||
+                TypeTags.isIntegerTypeTag(fieldType.tag);
     }
 
     @Override