Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: os: swap: increase wiggle room in swap check #3612

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

rcooke-warwick
Copy link
Contributor

@rcooke-warwick rcooke-warwick commented Feb 6, 2025

We encountered the variance in expected and measured swap in the rpi5 to be higher than the allowed value of 10 - to make this safe and allowing of more device types, changed the allowed variation - still small enough to actually check the value is right, but should reduce false negatives

required to unblock raspberrypi5 work
https://balena.fibery.io/search/Yc6vY#Work/Project/Support-new-raspberry-Pi-CM5-device-type-949

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@flowzone-app flowzone-app bot merged commit c33f28f into master Feb 6, 2025
160 of 162 checks passed
@flowzone-app flowzone-app bot deleted the ryan/swap branch February 6, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants