Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balena-image-flasher: depend on balena-image:do_image_complete #3589

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mtoman
Copy link
Contributor

@mtoman mtoman commented Jan 8, 2025

At this moment balena-image-flasher depends on do_image_sign_digest and do_rootfs of balena-image, but this is not enough, as the signature symlink is only created by a postprocess script.

This patch replaces the two existing dependencies by do_image_complete, which should cover everything.


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

At this moment balena-image-flasher depends on do_image_sign_digest
and do_rootfs of balena-image, but this is not enough, as the signature
symlink is only created by a postprocess script.

This patch replaces the two existing dependencies by do_image_complete,
which should cover everything.

Change-type: patch
Signed-off-by: Michal Toman <[email protected]>
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman had a problem deploying to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Failure
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman had a problem deploying to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Failure
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman had a problem deploying to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Failure
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 08:04 — with GitHub Actions Inactive
Copy link
Contributor

flowzone-app bot commented Jan 8, 2025

Website deployed to CF Pages, 👀 preview link https://fe86922f.balena-os.pages.dev

@flowzone-app flowzone-app bot enabled auto-merge January 8, 2025 08:08
@mtoman mtoman temporarily deployed to balena-cloud.com January 8, 2025 08:42 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-cloud.com January 8, 2025 08:42 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-cloud.com January 8, 2025 08:42 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-cloud.com January 8, 2025 09:07 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-cloud.com January 8, 2025 09:07 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-cloud.com January 8, 2025 09:07 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-cloud.com January 8, 2025 09:13 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-cloud.com January 8, 2025 09:13 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-cloud.com January 8, 2025 09:13 — with GitHub Actions Inactive
@mtoman mtoman requested a review from alexgg January 8, 2025 09:20
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 09:46 — with GitHub Actions Inactive
@mtoman mtoman temporarily deployed to balena-staging.com January 8, 2025 09:46 — with GitHub Actions Inactive
@flowzone-app flowzone-app bot merged commit 16c5474 into master Jan 8, 2025
161 of 163 checks passed
@flowzone-app flowzone-app bot deleted the mtoman/flasher-dep branch January 8, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants