-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
balena-image-flasher: depend on balena-image:do_image_complete #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this moment balena-image-flasher depends on do_image_sign_digest and do_rootfs of balena-image, but this is not enough, as the signature symlink is only created by a postprocess script. This patch replaces the two existing dependencies by do_image_complete, which should cover everything. Change-type: patch Signed-off-by: Michal Toman <[email protected]>
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
had a problem deploying
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Failure
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
had a problem deploying
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Failure
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
had a problem deploying
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Failure
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 08:04 — with
GitHub Actions
Inactive
Website deployed to CF Pages, 👀 preview link https://fe86922f.balena-os.pages.dev |
mtoman
temporarily deployed
to
balena-cloud.com
January 8, 2025 08:42 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-cloud.com
January 8, 2025 08:42 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-cloud.com
January 8, 2025 08:42 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-cloud.com
January 8, 2025 09:07 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-cloud.com
January 8, 2025 09:07 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-cloud.com
January 8, 2025 09:07 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-cloud.com
January 8, 2025 09:13 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-cloud.com
January 8, 2025 09:13 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-cloud.com
January 8, 2025 09:13 — with
GitHub Actions
Inactive
alexgg
approved these changes
Jan 8, 2025
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 09:46 — with
GitHub Actions
Inactive
mtoman
temporarily deployed
to
balena-staging.com
January 8, 2025 09:46 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment
balena-image-flasher
depends ondo_image_sign_digest
and do_rootfs ofbalena-image
, but this is not enough, as the signature symlink is only created by a postprocess script.This patch replaces the two existing dependencies by
do_image_complete
, which should cover everything.Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines