Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update checkout settings #3524

Merged
merged 1 commit into from
Sep 27, 2024
Merged

CI: Update checkout settings #3524

merged 1 commit into from
Sep 27, 2024

Conversation

Page-
Copy link
Contributor

@Page- Page- commented Sep 27, 2024

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Change-type: patch
@Page- Page- requested a review from klutchell September 27, 2024 13:26
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- had a problem deploying to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Failure
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-staging.com September 27, 2024 13:27 — with GitHub Actions Inactive
@Page- Page- enabled auto-merge September 27, 2024 13:28
Copy link

github-actions bot commented Sep 27, 2024

Website deployed to CF Pages, 👀 preview link https://50943deb.balena-os.pages.dev

@@ -55,6 +55,7 @@ jobs:
# The default GITHUB_TOKEN does not have workflow scope
# This is needed to push a new branch with workflow files
token: ${{ steps.gh_app_token.outputs.token }}
persist-credentials: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just so we can easily find which repos are using the insecure method, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it lets us find them and also makes it clear to everyone looking at the workflow that it's the case, basically raising awareness

@Page- Page- temporarily deployed to balena-cloud.com September 27, 2024 14:06 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-cloud.com September 27, 2024 14:06 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-cloud.com September 27, 2024 14:06 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-cloud.com September 27, 2024 14:19 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-cloud.com September 27, 2024 14:19 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-cloud.com September 27, 2024 14:19 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-cloud.com September 27, 2024 14:25 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-cloud.com September 27, 2024 14:25 — with GitHub Actions Inactive
@Page- Page- temporarily deployed to balena-cloud.com September 27, 2024 14:25 — with GitHub Actions Inactive
@Page- Page- merged commit 3e6a2a8 into master Sep 27, 2024
157 of 159 checks passed
@Page- Page- deleted the checkout-settings branch September 27, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants