Skip to content

Commit

Permalink
dunfell/honister: remove obsolete systemd patch
Browse files Browse the repository at this point in the history
The patch applied to systemd addressed this upstream moby issue:
moby/moby#27202

This was fixed in containerd 1.0.2:
containerd/console@c358734

This fix is present in balena engine since v17.13.5, which has been in
use since commit 53ce147. Drop this patch from meta-balena-dunfell and
later.

Change-type: patch
Signed-off-by: Joseph Kogut <[email protected]>
  • Loading branch information
jakogut committed Mar 21, 2023
1 parent 1a5820f commit 494ce63
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 66 deletions.

This file was deleted.

6 changes: 0 additions & 6 deletions meta-balena-dunfell/recipes-core/systemd/systemd_%.bbappend
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
FILESEXTRAPATHS_append := ":${THISDIR}/${PN}"

SRC_URI_append = " \
file://0001-core-Don-t-redirect-stdio-to-null-when-running-in-co.patch \
"

PACKAGECONFIG_remove = "nss-resolve"

do_install_append() {
Expand Down

This file was deleted.

6 changes: 0 additions & 6 deletions meta-balena-honister/recipes-core/systemd/systemd_%.bbappend
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
FILESEXTRAPATHS:append := ":${THISDIR}/${PN}"

SRC_URI:append = " \
file://0001-core-Don-t-redirect-stdio-to-null-when-running-in-co.patch \
"

PACKAGECONFIG:remove = "nss-resolve"

do_install:append() {
Expand Down

3 comments on commit 494ce63

@shaunco
Copy link

@shaunco shaunco commented on 494ce63 Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakogut - I've been trying to figure out why open-balena-api, open-balena-s3, etc all only print a single log line of Systemd init system enabled. to the docker logs (pseudo-console) ... any chance this patch is needed again?

@jakogut
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaunco
Copy link

@shaunco shaunco commented on 494ce63 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakogut - Sorry if I wasn't clear. I know where that one line comes from. I'm trying to sort out why no other log lines are printed to stdout/stderr ... or why stdout/stderr are not sent to tty. Without the core-Don-t-redirect-stdio-to-null-when-running-in-co.patch, stdio is all redirected to /dev/null when running in a container.

Please sign in to comment.