Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info to error messages when using min/max as column names #1600

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Add more info to error messages when using min/max as column names #1600

merged 3 commits into from
Apr 30, 2019

Conversation

alxndrsn
Copy link

No description provided.

@alxndrsn alxndrsn mentioned this pull request Apr 26, 2019
Open
@rachaelshaw
Copy link
Member

@alxndrsn Thanks for helping improve these error messages! I went ahead and made a couple changes before merging:
• Moved the additional text below the example code in the error messages, just so people don't get confused about what the example is demonstrating (i.e. so they don't assume it's an example of things not working as expected)
• Added the same message for groupBy, sum, and average, since those have the same problem

@rachaelshaw rachaelshaw merged commit f1fd3f8 into balderdashy:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachaelshaw rachaelshaw rachaelshaw approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxndrsn @rachaelshaw