Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manytomanythrough fix and failling test for #1133 #1134

Merged
merged 5 commits into from
Nov 23, 2015
Merged

Manytomanythrough fix and failling test for #1133 #1134

merged 5 commits into from
Nov 23, 2015

Conversation

atiertant
Copy link

@atiertant atiertant changed the title Manytomanythrough failling test for https://github.com/balderdashy/waterline/issues/1133 Manytomanythrough failling test for #/1133 Sep 2, 2015
@atiertant atiertant changed the title Manytomanythrough failling test for #/1133 Manytomanythrough failling test for #1133 Sep 2, 2015
@atiertant atiertant mentioned this pull request Oct 26, 2015
Merged
@atiertant atiertant changed the title Manytomanythrough failling test for #1133 Manytomanythrough fix and failling test for #1133 Oct 26, 2015
@weyert
Copy link

weyert commented Oct 31, 2015

Failing??

@atiertant
Copy link
Author

@weyert this test and fix require balderdashy/waterline-schema#30

@particlebanana particlebanana mentioned this pull request Nov 20, 2015
Closed
particlebanana added a commit that referenced this pull request Nov 23, 2015
@particlebanana
Merge pull request #1134 from atiertant/manytomanythrough
1deb810 
Manytomanythrough fix and failling test for #1133
@particlebanana particlebanana merged commit 1deb810 into balderdashy:master Nov 23, 2015
particlebanana added a commit to particlebanana/waterline that referenced this pull request Nov 23, 2015
@particlebanana
fix .add and .remove to get the tests from balderdashy#1134 passing
dd9a015
@particlebanana particlebanana mentioned this pull request Nov 23, 2015
Merged
particlebanana added a commit that referenced this pull request Nov 23, 2015
@particlebanana
Merge pull request #1230 from particlebanana/add-remove-tests
66d6a0b 
Fix test suite from #1134
@particlebanana
Copy link
Contributor

Alright @atiertant everything looks good in master and all tests are passing. I cherry picked these commits into the 0.10.x stable branch and went ahead and published 0.10.28 to npm.

Thanks again for all your hard work with this! The next thing we need to do is update the docs for through with a better explaination of where they stand as of now. Then I would like to look into @devinivy's issue with lifecycle callbacks on through tables.

@devinivy
Copy link
Contributor

Brilliant work!

@dmarcelino
Copy link
Member

Awesome stuff, congrats @atiertant 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atiertant @weyert @particlebanana @devinivy @dmarcelino