Skip to content

Commit

Permalink
Bump socket.io-client to v1.7.3
Browse files Browse the repository at this point in the history
  • Loading branch information
sgress454 committed Apr 6, 2017
1 parent 317b117 commit bd51bd7
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"request": "2.74.0",
"sails": "^1.0.0-16",
"sails-hook-sockets": "^1.2.3",
"socket.io-client": "1.7.1"
"socket.io-client": "1.7.2"
},
"scripts": {
"test": "node ./node_modules/mocha/bin/mocha -b --reporter spec --timeout 10000",
Expand All @@ -47,5 +47,8 @@
"bugs": {
"url": "https://github.com/balderdashy/sails.io.js/issues"
},
"homepage": "https://github.com/balderdashy/sails.io.js"
"homepage": "https://github.com/balderdashy/sails.io.js",
"dependencies": {
"socket.io-client": "1.7.3"

This comment has been minimized.

Copy link
@rachaelshaw

rachaelshaw Apr 21, 2017

Member

@sgress454 @mikermcneil does this need to be a dependency? I don't think we're using it anywhere in this package

This comment has been minimized.

Copy link
@sgress454

sgress454 Apr 21, 2017

Author Member

It should be a devDependency, probably did --save instead of --save-dev at some point.

This comment has been minimized.

Copy link
@sgress454

sgress454 Apr 21, 2017

Author Member

@rachaelshaw (it's used for tests)

This comment has been minimized.

Copy link
@rachaelshaw

rachaelshaw Apr 21, 2017

Member

ah makes sense, looks like it ended up in both places: bd51bd7#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R26 is 1.7.2 and this is 1.7.3 (trying to figure out a different problem, not sure if it's related or not)

}
}

0 comments on commit bd51bd7

Please sign in to comment.