Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Add mapping for NDX token price on Arbitrum #816

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

rabmarut
Copy link
Contributor

@rabmarut rabmarut commented Sep 13, 2021

Description

Add ChainMap entry for the Indexed Finance NDX token, mapping its Arbitrum address to its Ethereum address:
0xB965029343D55189c25a7f3e0c9394DC0F5D41b1 -> 0x86772b1409b61c639EaAc9Ba0AcfBb6E238e5F83

The address pairing used above can be found in Arbitrum's official token list: https://bridge.arbitrum.io/token-list-42161.json

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

  • Verify that the dedicated page for this pool ID (on Arbitrum!) displays a dollar value for the NDX token: 0x5ced962afbfb7e13fb215defc2b027678237aa3a000200000000000000000011
  • Verify that this warning is not shown for the same pool: "Price information is missing for this pool, since it contains a token not found by our price provider."

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Sep 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/8aBtGzSh1BpH7WHu2Xyu4cow7hL1
✅ Preview: Canceled

[Deployment for c563ccd canceled]

app – ./

🔍 Inspect: https://vercel.com/balancer/app/HfCTo89b2DMLmzzFvZHgdML59CRd
✅ Preview: Canceled

[Deployment for c563ccd canceled]

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/HvJDvqT3cbqufbQx4dPq8JBkeN2Y
✅ Preview: https://staging-app-git-arbitrum-ndx-price-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/FL2joNd5H9FHpEiHaeQU1nN1wE3X
✅ Preview: https://staging-kovan-app-git-arbitrum-ndx-price-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/9J5z2bKaEcGA7fdzkyzKyA5oTmrd
✅ Preview: https://gnosis-git-arbitrum-ndx-price-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/6E4y8MDk6ML84jpbEmrM5dTQZvb2
✅ Preview: Canceled

[Deployment for c563ccd canceled]

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/Cuo31bBNCNqmge3jsCMtbHCyDp8y
✅ Preview: https://beta-polygon-git-arbitrum-ndx-price-balancer.vercel.app

beta-arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/beta-arbitrum/AguaVb8Lt1AiGtRXFrzNTzA9FVPD
✅ Preview: https://beta-arbitrum-git-arbitrum-ndx-price-balancer.vercel.app

arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/arbitrum/AHeypG8sQsARU2XmX2Yojsa5SraK
✅ Preview: Canceled

[Deployment for c563ccd canceled]

@garethfuller garethfuller merged commit f37a20d into master Sep 14, 2021
@garethfuller garethfuller deleted the arbitrum-ndx-price branch September 14, 2021 08:39
This was referenced Sep 15, 2021
evgenyboxer added a commit that referenced this pull request Sep 16, 2021
* Hotfix: Add mapping for NDX token price on Arbitrum (#816)

* Add mapping for NDX token price on Arbitrum

* 1.19.1

* add LBP pool type

* 1.19.3

* more tweaks for LBP

* refactor: use poolType instead of pool to determine type

Co-authored-by: rabmarut <[email protected]>
Co-authored-by: Gareth Fuller <[email protected]>
This was referenced Sep 16, 2021
evgenyboxer added a commit that referenced this pull request Sep 16, 2021
* Hotfix: Add mapping for NDX token price on Arbitrum (#816)

* Add mapping for NDX token price on Arbitrum

* 1.19.1

* hotfix/1.19.3 (#822)

* add LBP pool type

* 1.19.3

* more tweaks for LBP

* refactor: use poolType instead of pool to determine type

* fix: correctly identifying stable pools

Co-authored-by: rabmarut <[email protected]>
Co-authored-by: Gareth Fuller <[email protected]>
@evgenyboxer evgenyboxer mentioned this pull request Sep 16, 2021
evgenyboxer added a commit that referenced this pull request Sep 16, 2021
* Hotfix: Add mapping for NDX token price on Arbitrum (#816)

* Add mapping for NDX token price on Arbitrum

* 1.19.1

* hotfix/1.19.3 (#822)

* add LBP pool type

* 1.19.3

* more tweaks for LBP

* refactor: use poolType instead of pool to determine type

* fix: correctly identifying stable pools (#825)

* 1.19.4

Co-authored-by: rabmarut <[email protected]>
Co-authored-by: Gareth Fuller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants