Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported network bugs #759

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Aug 30, 2021

Description

If the user's wallet is connected to a network that we don't have a config for a few bugs existed:

  • The warning and request to switch network banner didn't appear
  • The user's account btn in the nav disappeared.

This PR fixes these bugs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Try to connect to the app with an unsupported network, e.g. xDai, and see if anything breaks.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Aug 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/8mX2uKsR4G1ySybCCvxPmFHyjspy
✅ Preview: Canceled

[Deployment for c13b0f6 canceled]

app – ./

🔍 Inspect: https://vercel.com/balancer/app/H2tq3kRL3nyPNHh1fG1uHmLrZrCw
✅ Preview: Canceled

[Deployment for c13b0f6 canceled]

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/Hi1TR11bxoH8KHnkAKxxd9bhbogp
✅ Preview: https://staging-app-git-gareth-fix-unsupported-networks-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/G9cc3YmDWFbMazy8NVm82oC2wPvA
✅ Preview: https://staging-kovan-app-git-gareth-fix-unsupported-networks-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/BMBZ9abBvvVfSWyj6x5pM62zv8u2
✅ Preview: https://gnosis-git-gareth-fix-unsupported-networks-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/CNXb4gtYQP41FsSEm1WjAqVH4LhC
✅ Preview: Canceled

[Deployment for c13b0f6 canceled]

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/HYw4TBxmCxto4yTsoDgG8Vo681fD
✅ Preview: https://beta-polygon-git-gareth-fix-unsupported-networks-balancer.vercel.app

beta-arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/beta-arbitrum/4cvphh6yWF2WLYbPVUHZHcSkpvF9
✅ Preview: https://beta-arbitrum-git-gareth-fix-unsupported-networks-balancer.vercel.app

arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/arbitrum/9grxzr2E272fQyDCRBccXhHk19yT
✅ Preview: Canceled

[Deployment for c13b0f6 canceled]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant