Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: highlighted ecosystem pools section #758

Merged
merged 12 commits into from
Sep 1, 2021

Conversation

arb000r
Copy link
Collaborator

@arb000r arb000r commented Aug 30, 2021

Description

As part of the ecosystem pools project we want to show that we have partner pools on our Home page

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

How should this be tested?

Test both mobile and desktop that there are ecosystem pools on the home page

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • My changes generate no new console warnings
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Aug 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/kovan-app/3ck7DH7Db6u4YsTmC3x1Mgmd8hd4
✅ Preview: Canceled

[Deployment for ef73849 canceled]

app – ./

🔍 Inspect: https://vercel.com/balancer/app/CANxsTapZF6REgwJcGp1ARwttrsB
✅ Preview: Canceled

[Deployment for ef73849 canceled]

staging-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-app/A9Pv46eUracMYqrCB5vB5KZ13Xut
✅ Preview: https://staging-app-git-ui-707-ecosystem-pools-2-balancer.vercel.app

staging-kovan-app – ./

🔍 Inspect: https://vercel.com/balancer/staging-kovan-app/49zUqftchUNsSPMzaSRptHwbVKuS
✅ Preview: https://staging-kovan-app-git-ui-707-ecosystem-pools-2-balancer.vercel.app

gnosis – ./

🔍 Inspect: https://vercel.com/balancer/gnosis/GeB8d8nKTzn44wwX8AZV3GTegzZc
✅ Preview: https://gnosis-git-ui-707-ecosystem-pools-2-balancer.vercel.app

polygon – ./

🔍 Inspect: https://vercel.com/balancer/polygon/HyK1y2LXowTr7wSXhmxtU4x9a6qP
✅ Preview: Canceled

[Deployment in progress for ef73849]

beta-polygon – ./

🔍 Inspect: https://vercel.com/balancer/beta-polygon/J9XPnrPRUBaZKR8ygKJgBKATDxdP
✅ Preview: https://beta-polygon-git-ui-707-ecosystem-pools-2-balancer.vercel.app

beta-arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/beta-arbitrum/FrCUbnEzmd9ruB1Soh7ugFr4SaPA
✅ Preview: https://beta-arbitrum-git-ui-707-ecosystem-pools-2-balancer.vercel.app

arbitrum – ./

🔍 Inspect: https://vercel.com/balancer/arbitrum/CALXGxjvV9SfbV1a8Sa6zB6qmJUe
✅ Preview: Canceled

[Deployment for ef73849 canceled]

@evgenyboxer
Copy link
Contributor

@1saf could you please fix lint issues

* Update BalCard

* Refactor FeaturedPools

* Slight padding adjustment
@@ -37270,6 +37270,7 @@
"version": "4.5.12",
"dev": true,
"requires": {
"@babel/core": "^7.11.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this gets added sometimes. Could you try deleting you node modules and re-installing to see if this disappears?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didnt change anything

@TomAFrench
Copy link
Contributor

Should we display Element.fi to users who are connected to Polygon? It seems like we might want to restrict this to mainnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants