Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Block joins page if unapproved rate provider #5560

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Apr 16, 2024

Description

See title.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Test that you cannot access the add-liquidity path if a rate provider is unapproved for a pool.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@garethfuller garethfuller requested a review from agualis April 16, 2024 08:19
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 9:43am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2024 9:43am

@garethfuller garethfuller merged commit a86060a into master Apr 16, 2024
6 checks passed
@garethfuller garethfuller deleted the fix/block-joins-rate-provider branch April 16, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants