Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Minor RPC init optimization #4195

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

garethfuller
Copy link
Collaborator

@garethfuller garethfuller commented Sep 12, 2023

Description

Prevents two different json providers being initialized when it's not needed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 9:43am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 18, 2023 9:43am

@garethfuller garethfuller merged commit a8ca451 into master Sep 19, 2023
@garethfuller garethfuller deleted the hf/rpc-init-optimize branch September 19, 2023 08:12
garethfuller added a commit that referenced this pull request Sep 22, 2023
* hotfix: Minor RPC init optimization (#4195)

* chore: Optimize provider initiation

* chore: We should only ever be instatiating the static provider

* 1.124.1

* chore: Add 50WETH-50USDC pool to base allowlist

* 1.124.2

* chore: Add axlBAL/BAL pool to arbitrum allowlist (#4211)

Co-authored-by: balopco <[email protected]>

* 1.124.3

* chore: Add 50WETH/50-4Pool pool to arbitrum allowlist

* 1.124.4

* weekly gauge update (#4220)

* 1.124.5

* chore: Add 80OVN/20wUSD+ pool to arbitrum allowlist (#4218)

Co-authored-by: balopco <[email protected]>

* 1.124.6

* chore: Add 50wstETH/50-4Pool pool to arbitrum allowlist (#4217)

Co-authored-by: balopco <[email protected]>
Co-authored-by: ZeKraken <[email protected]>

* 1.124.7

* fix: Base bal minter address

* chore: Fix Avax bal minter

---------

Co-authored-by: Alberto Gualis <[email protected]>
Co-authored-by: Automated Version Bump <[email protected]>
Co-authored-by: balopco <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tritium <[email protected]>
Co-authored-by: ZeKraken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants