Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: update wallet network on switch #4118

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

timjrobinson
Copy link
Contributor

Description

When testing with walletconnect I noticed the walletNetwork tag was not being updated when changing network in your wallet. This is causing the users wallet network to be reported incorrectly.

Also switches it to network slug to be consistent with appNetwork, and fixes a bug where this would error if the user is connected to a network we don't support.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  • Add a breakpoint in the watch statement
  • Change networks in your wallet and ensure it hits the breakpoint and switches correctly.
  • Switch to an unsupported network and ensure it sets the walletNetwork to the chainId and doesn't error.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
beta-app-v2 ✅ Ready (Inspect) Visit Preview Aug 29, 2023 10:43am
1 Ignored Deployment
Name Status Preview Updated (UTC)
app-v2 ⬜️ Ignored (Inspect) Aug 29, 2023 10:43am

@timjrobinson timjrobinson merged commit 1fce422 into master Aug 29, 2023
@garethfuller garethfuller deleted the hf/update-wallet-network-on-switch branch August 29, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants