Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: crosschain lp #1584

Open
wants to merge 152 commits into
base: master
Choose a base branch
from
Open

Feat: crosschain lp #1584

wants to merge 152 commits into from

Conversation

0xmilktea
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
balanced-network-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 5:11pm
balanced-network-stats ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 5:11pm
hanaswap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 5:11pm

@parrot9design
Copy link
Collaborator

parrot9design commented Feb 6, 2025

  • There seems to be a gradient style applied to the Havah logo. It should be dark green (first image), but when it's much brighter when moved to the bottom of the list.
    Screenshot 2025-02-06 at 1 23 21 PM Screenshot 2025-02-06 at 1 23 30 PM

  • What order is being used when every chain has zero rewards? Might be best to still default to alphabetical until one of them has a value above $0.
    Screenshot 2025-02-06 at 1 29 25 PM

  • The Supply asset selectors don't always show the amount you have in your wallet:
    Screenshot 2025-02-06 at 1 32 21 PM Screenshot 2025-02-06 at 1 32 26 PM

Screenshot 2025-02-06 at 2 13 52 PM Screenshot 2025-02-06 at 2 13 56 PM Screenshot 2025-02-06 at 2 14 05 PM


  • Still getting the issue with gas. The warning came up just after I clicked Send for the second asset, and disappeared once the second asset had been sent, and then the final supply transaction failed. Note that I still had at least 1 SUI in my wallet after signing all of these transactions.
Screen.Recording.2025-02-06.at.1.35.18.PM.mov

I added more to my wallet so I could try again, but that Supply transaction also failed.

  • After I removed the second asset from the contract, it went into the Sending state for at least 10-20 seconds before changing back to Send.
    Screenshot 2025-02-06 at 1 54 40 PM

  • I thought we were going to prevent people from supplying liquidity on Archway and Havah? There's only one pool available on Havah (HVH/bnUSD), and it's not even active yet. sARCH/bnUSD could work, but people won't be able to earn any BALN for it on Archway.
    Screenshot 2025-02-06 at 3 02 42 PM

  • Anything that's only available on a single chain, like ICX, should include the chain logo:
    Screenshot 2025-02-06 at 2 01 09 PM

  • Every transaction is taking an extra ~1.5 minutes to finalise in the app after being marked as complete on xcallscan. Here's a swap:
    Screenshot 2025-02-06 at 2 08 34 PM

And here's how it affected a supply transaction, where 2 of the 3 transactions took 4.5 minutes:
https://github.com/user-attachments/assets/04490805-1763-44fb-bdd3-26a33a0a5d30
I couldn't complete the final Supply transaction because the fee issue kicked in once again. In this case, the fee mentioned in the message kept changing. First it was 0.0003 ETH, then 0.0002 ETH, then 0.0001 ETH. We should not allow users to even begin sending assets to Balanced if they won't have enough gas to see it through.

And like the failed transaction on Sui mentioned above, after I refreshed the page I discovered that I had 0.00211 ETH – plenty to see this transaction through.


  • Changed my mind regarding the 'switch network' handling, as the current implementation doesn't pass the squint test. Let's do it this way instead:
    Screenshot 2025-02-06 at 2 17 56 PM

  • You can use the 25/50/75/100 buttons to exceed the amount available to supply. We should limit it to 100% of either asset, so you never see an "insufficient {asset} balance" message.
Screen.Recording.2025-02-06.at.3.27.20.PM.mov

  • Show the onboarding text for the Savings Rate section instead of asset totals for non-ICON chains, as you can't earn rewards for this yet.
    Screenshot 2025-02-06 at 2 36 34 PM

  • The Rewards dropdown is hard to use & see which chains you're earning rewards for. If you're earning rewards (e.g. supplying liquidity), include the $ amount of pending rewards (e.g. $0.01), but don't include more than 2 decimal places. If you're not earning rewards on a chain, show N/A` instead:
    Screenshot 2025-02-06 at 2 40 55 PM


  • The Liquidity Pools section looks broken on mobile:
    image
    Wondering if we just hide the pool name on smaller screens, since you can already see the two assets you've supplied.

  • Adjust the liquidity rewards tooltip when ICON isn't the active chain:
    image
    Let's make it so the content instead says:

Your return:

  • {asset 1}/{asset 2}: {amount}%
  • {asset 1}/{asset 2}: {amount}%

And if you haven't supplied any liquidity on that chain, the tooltip should be hidden entirely.


  • I've staked LP tokens and this is an incentivised pool, so it shouldn't say N/A here:
    IMG_0828
    Screenshot 2025-02-06 at 3 59 48 PM

(I know they're small amounts, but it's better to use that than make it seem like people haven't taken the necessary steps to earn rewards.)

… should be dark green (first image), but when it's much brighter when moved to the bottom of the list.
@swiftcc624
Copy link
Collaborator

swiftcc624 commented Feb 6, 2025

@parrot9design

image

Can you give me the onboarding text?

Anything that's only available on a single chain, like ICX, should include the chain logo:

can you explain more?

…current implementation doesn't pass the squint test. Let's do it this way instead:
…ble to supply. We should limit it to 100% of either asset, so you never see an "insufficient {asset} balance" message.
@parrot9design
Copy link
Collaborator

Can you give me the onboarding text?

It's already in the product:
Screenshot 2025-02-07 at 6 20 10 AM

Anything that's only available on a single chain, like ICX, should include the chain logo:

can you explain more?

ICX is only available on ICON. Which means it should have the ICON blockchain logo attached, just like it does in the Supply tab in the live app. This image should've been enough explanation.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement cross chain lp feature for front end
4 participants