Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement wICX #1536

Merged
merged 29 commits into from
Jan 8, 2025
Merged

Implement wICX #1536

merged 29 commits into from
Jan 8, 2025

Conversation

hetfly
Copy link
Collaborator

@hetfly hetfly commented Nov 20, 2024

close #1534

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
balanced-network-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:56am
balanced-network-stats ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:56am
hanaswap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:56am
hswap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:56am

@hetfly
Copy link
Collaborator Author

hetfly commented Nov 21, 2024

@FezBox managed to temporarily put in a check for a better trade using the queue while there is still liquidity. We will have to do a clean up after the queue is emptied and deprecated anyway, there is lot's of conditional code using the queue.

Can we get some liquidity in the new pool so that we can properly test the routing and trade picking? (queue vs wICX)

@parrot9design only when supplying and trading into ICX, wICX contract is used, but it's all abstracted from the user and ICX symbol is displayed instead of wICX. While we have the queue working in parallel temporarily, do we want to differentiate the wICX contract somehow? At least in Your pools section, we could show wICX/sICX as the pool name? If the user had both, the queue and wICX/sICX in that section, it could look a bit confusing.

@hetfly hetfly requested a review from parrot9design November 21, 2024 13:32
@parrot9design
Copy link
Collaborator

Let's use ICX / sICX to identify the new pool so we can omit all mention of wICX from the UI.

We can call the old one the ICX queue:
Screenshot 2024-11-22 at 1 05 10 PM

@parrot9design
Copy link
Collaborator

There are still a few mentions of wICX in the UI:
Screenshot 2024-11-25 at 10 29 22 AM Screenshot 2024-11-25 at 10 29 32 AM
Screenshot 2024-11-25 at 10 32 46 AM

The asset selectors treat ICX as though it's wICX, as it should be above sICX when the list is ordered alphabetically.
Screenshot 2024-11-25 at 10 28 39 AM

When you choose ICX, can we make the second asset default to sICX instead of bnUSD?

Also, shouldn't we be able to stake LP tokens for the new pool?
Screenshot 2024-11-25 at 10 36 59 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wICX implementation
3 participants