Zmiany od czasu publikacji #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes from forum
Zamyka wszystkie deskryptory z poza zarezerwowanego zakresu, aby upewnić się że biblioteka trzyma wszystko w zarezerwowanym dla siebie zakresie
Obstruction test fix
Add .gitignore
Fix bug which causes messages processing delays to increase proportionally with their size not number of atomic blocks they fit into.
Extend `bare_reduce` example with ability to specify with flag length of message to be reduced. Therefore now `bare_reduce` can be used to test effectiveness of reduce called on big messages.
Adjust effectiveness requirements for long messages.
Update specification to disallow delay on chrecv.
Rename channels delay env vars to mitigate clashes with mimpi reserved ones.
Change `bare_barrier`, `bare_reduce` and `broadcast` examples to activate chsend delay only for time of execution of function which effectiveness is measured. Update test cases accordingly (to avoid clash with mimpi reserved env variable).
Big messages effectiveness
Testing facilities upgrade
This is a good practice in header files to prevent duplicated definition errors when linking.
It can be used for checking equality with any MIMPI_Retcode. In a sense, it extends `ASSERT_MIMPI_OK`.
for better debug experience.
Drobna poprawka do testów
Test enhancements
Kilka testów
`errno` global variable was queried for error code instead of checking content of `_errno` local variable.
fix bug in ASSERT_ZERO
Flush stdout in extended_hello test
Valgrind & drobne testy
valgrind complains (and it is probably right) that stack is being corrupted in deadlock5 and deadlock6. It is due to large arrays being allocated on stack. This is solved by allocating them in static memory (BSS region).
avoid stack corruption due to large arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gałąź main zawiera treść zaktualizowaną o odpowiedzi z forum, natomiast original-main treść w wersji takiej jaką ją na początek opublikowaliśmy. Tych, którzy przeczytali już treść, zachęcamy do przejrzenia zmian wyszczególnionych w tym pull request (nie będzie on zamykany). Natomiast tych, którzy jeszcze nie zaczęli, zachęcamy do czytania treści od razu w aktualnej wersji.