-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fix #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: - `examples/test.h`: Header library which provide helper utilities to mark test as succeed or failed. - `run_test` Helper script which detects whether any worker failed on test_assert (function from `test.h`) or haven't call test_success before exit Those utilities combined helps write reliable tests which don't depends on mimpirun propagating errors from workers
Update tests to facilitate new testing utilities which don't rely on mimpirun return code.
Change `test` to only run tests specified by positional arguments if any are present. In case no arguments are passed `test` nearly behavior is unchanged.
Improve `test` script to traverses directories recursively if given ones.
wprzytula
requested changes
Jan 1, 2024
run_test
Outdated
result=0 | ||
|
||
# Check if all workers finished sucessfully | ||
# - num of <<success>> is equeal to number of created workers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
equal*
run_test
Outdated
# Remove temporary file | ||
rm "$tmp_file" | ||
|
||
# Exit with appropraite return code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test
script with option to specify which tests to run allowing creation of bundles of tests (with directories)tests/
directory totests/basic
to create space for students testsmimpirun
return code propagation