Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Pyright to report import cycles #585

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Configure Pyright to report import cycles #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1905504
Configure Pyright to report import cycles
disrupted Jan 14, 2025
6075437
Fix import cycle in streams-bootstrap v2 module
disrupted Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kpops/components/streams_bootstrap_v2/producer/producer_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
OutputTopicTypes,
TopicConfig,
)
from kpops.components.streams_bootstrap_v2 import StreamsBootstrapV2
from kpops.components.streams_bootstrap_v2.base import StreamsBootstrapV2
from kpops.components.streams_bootstrap_v2.producer.model import ProducerAppV2Values
from kpops.const.file_type import DEFAULTS_YAML, PIPELINE_YAML
from kpops.utils.docstring import describe_attr
Expand All @@ -21,7 +21,7 @@
log = logging.getLogger("ProducerAppV2")


class ProducerAppCleaner(KafkaAppCleaner, StreamsBootstrapV2):

Check warning on line 24 in kpops/components/streams_bootstrap_v2/producer/producer_app.py

View workflow job for this annotation

GitHub Actions / Lint (ubuntu-24.04, 3.11, false) 

Base classes for class "ProducerAppCleaner" define variable "from_" in incompatible way
values: ProducerAppV2Values

@property
Expand Down
2 changes: 1 addition & 1 deletion kpops/components/streams_bootstrap_v2/streams/streams_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from kpops.components.base_components.kafka_app import KafkaAppCleaner
from kpops.components.common.app_type import AppType
from kpops.components.common.topic import KafkaTopic
from kpops.components.streams_bootstrap_v2 import StreamsBootstrapV2
from kpops.components.streams_bootstrap_v2.base import StreamsBootstrapV2
from kpops.components.streams_bootstrap_v2.streams.model import (
StreamsAppV2Values,
)
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ asyncio_mode = "auto"
asyncio_default_fixture_loop_scope = "function"

[tool.pyright]
reportImportCycles = true

reportUnknownParameterType = "warning"
reportUnknownArgumentType = "warning"
reportUnknownLambdaType = "warning"
Expand Down
Loading