Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hash and trim long Helm release names instead of only trimming #390

Merged
merged 34 commits into from
Jan 2, 2024
Merged

Use hash and trim long Helm release names instead of only trimming #390

merged 34 commits into from
Jan 2, 2024

Conversation

raminqaf
Copy link
Contributor

@raminqaf raminqaf commented Nov 21, 2023 •
edited
Loading

fixes #46

@raminqaf raminqaf self-assigned this Nov 21, 2023
@raminqaf raminqaf added the type/refactor Refactoring of existing functionality label Nov 21, 2023
@raminqaf raminqaf changed the title WIP: Use hash name instead of trimming long Helm release names Use hash name instead of trimming long Helm release names Nov 21, 2023
@raminqaf raminqaf marked this pull request as ready for review November 21, 2023 10:12
sujuka99
sujuka99 previously approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@sujuka99 sujuka99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

disrupted
disrupted reviewed Dec 6, 2023
View reviewed changes
@disrupted
Copy link
Member

fixes #46 and #327

does GH understand this? I believe you need to put them in separate lines

fixes #46
fixes #327

@raminqaf raminqaf added the breaking-change Indicates that this PR introduces a breaking change label Dec 6, 2023
@raminqaf raminqaf changed the base branch from main to v3 December 8, 2023 14:03
@raminqaf raminqaf changed the base branch from v3 to main December 8, 2023 14:05
@raminqaf raminqaf requested a review from disrupted December 12, 2023 14:39
disrupted
disrupted reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test it with a deployment?

@raminqaf raminqaf requested a review from disrupted December 12, 2023 16:16
@raminqaf raminqaf requested a review from sujuka99 December 20, 2023 13:18
sujuka99
sujuka99 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@sujuka99 sujuka99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's tested with a deployment, LGTM

@raminqaf
Merge branch 'v3' of github.com:bakdata/kpops into feature/use-fullna…
5d98313 
…me-override

# Conflicts:
#	tests/pipeline/snapshots/snap_test_example.py
#	tests/pipeline/snapshots/snap_test_pipeline.py
@raminqaf
merge v3
873553b
@raminqaf
Merge branch 'v3' into feature/use-fullname-override
539efab
@disrupted disrupted changed the title Use hash and trim long helm release names instead of only trimming Use hash and trim long Helm release names instead of only trimming Dec 21, 2023
@raminqaf raminqaf merged commit 4a41594 into v3 Jan 2, 2024
6 of 7 checks passed
@raminqaf raminqaf deleted the feature/use-fullname-override branch January 2, 2024 13:01
@torbsto torbsto mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp94831 philipp94831 philipp94831 left review comments

@disrupted disrupted disrupted approved these changes

@sujuka99 sujuka99 sujuka99 approved these changes

@irux irux Awaiting requested review from irux

Assignees

@raminqaf raminqaf

Labels
breaking-change Indicates that this PR introduces a breaking change type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.

Remove name_override workaround for Helm apps Trim Helm release names based on a KPOps variable
4 participants
@raminqaf @disrupted @philipp94831 @sujuka99