Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to asyncio #301

Merged
merged 25 commits into from
Aug 8, 2023
Merged

Migrate to asyncio #301

merged 25 commits into from
Aug 8, 2023

Conversation

irux
Copy link
Contributor

@irux irux commented Jul 24, 2023 •
edited
Loading

closes #283

@irux irux marked this pull request as ready for review July 31, 2023 12:00
@disrupted
Copy link
Member

#282 is already done

@irux irux added the type/refactor Refactoring of existing functionality label Aug 1, 2023
disrupted
disrupted requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also make SchemaHandler async?

@irux irux requested a review from raminqaf August 2, 2023 08:57
@irux irux requested a review from disrupted August 2, 2023 08:57
disrupted
disrupted requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, just left some comments

disrupted
disrupted requested changes Aug 8, 2023
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, please create a dev branch for the entire async feature and change the base branch of this PR

@irux irux changed the base branch from main to feature/parallelization August 8, 2023 11:16
@irux irux merged commit 8db8896 into feature/parallelization Aug 8, 2023
@irux irux deleted the feature/implement-httpx branch August 8, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@sujuka99 sujuka99 Awaiting requested review from sujuka99

@raminqaf raminqaf Awaiting requested review from raminqaf

Assignees

@irux irux

Labels
type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor builtin components for AsyncIO
3 participants
@irux @disrupted @raminqaf