Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored API and added javadocs #10

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Refactored API and added javadocs #10

merged 2 commits into from
Mar 20, 2019

Conversation

AHeise
Copy link
Contributor

@AHeise AHeise commented Mar 8, 2019 •
edited
Loading

This change is Reviewable

@AHeise AHeise added the enhancement New feature or request label Mar 8, 2019
@AHeise AHeise requested a review from philipp94831 March 8, 2019 18:35
@AHeise AHeise mentioned this pull request Mar 10, 2019
Closed
philipp94831
philipp94831 reviewed Mar 11, 2019
View reviewed changes
core/src/main/java/com/bakdata/dedupe/deduplication/Deduplication.java
*
* @param <T> the type of the record
*/
public interface Deduplication<T> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a stream() method?

@AHeise AHeise merged commit c23b696 into master Mar 20, 2019
@AHeise AHeise deleted the refactor_api branch March 20, 2019 08:42
@AHeise AHeise mentioned this pull request Mar 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipp94831 philipp94831 philipp94831 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AHeise @philipp94831