This repository has been archived by the owner on Oct 3, 2022. It is now read-only.
client, templates: Round time properly #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
So, the test is failing because apparently https://github.com/pierrec/lz4 just did a breaking change with pierrec/lz4#33 |
|
I'll take a look come the weekend. Feel free to pile up PRs till then.
…On Wed, 5 Sep 2018, 14:03 チルノ, ***@***.***> wrote:
So, the test is failing because apparently https://github.com/pierrec/lz4
just did a breaking change with pierrec/lz4#33
<pierrec/lz4#33>
Would it be possible to have travis use go 1.11?
Same for my other PR.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#871 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHfPsH4vH67Qtji74kWwKdusmJ9px7Gvks5uX69vgaJpZM4WajgC>
.
|
|
You could probably just merge both and it would be fine, I tested both pretty thoroughly. |
|
I need to be made to be more thorough in reviewing.
…On Wed, 5 Sep 2018, 14:11 チルノ, ***@***.***> wrote:
You could probably just merge both and it would be fine, I tested both
pretty thoroughly.
Do what you feel is best though, of course.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#871 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHfPsNUmycU0cFs7puYiQwkKDlHHbRRFks5uX7FCgaJpZM4WajgC>
.
|
|
You know what I meant.
…On Wed, 5 Sep 2018, 14:17 meguca meguca, ***@***.***> wrote:
I need to be made to be more thorough in reviewing.
On Wed, 5 Sep 2018, 14:11 チルノ, ***@***.***> wrote:
> You could probably just merge both and it would be fine, I tested both
> pretty thoroughly.
> Do what you feel is best though, of course.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <#871 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AHfPsNUmycU0cFs7puYiQwkKDlHHbRRFks5uX7FCgaJpZM4WajgC>
> .
>
|
|
That's fair, honestly I think it's a good idea, and not just in my case. |
ghost
added
bakape
approved these changes
Sep 8, 2018
nekto-nekto
pushed a commit
to 0-chan-ru/tetuca
that referenced
this pull request
May 22, 2021
client, templates: Round time properly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the incorrect ban times.
It is rounding, so if you do 4 hours and 29 minutes, you will get 4 hours, and 5 hours with 4 hours and 31 minutes. 4 hours and 30 minutes (in the field) will result in 4 hours, because by it is actually 4 hours, 29 minutes and 59 seconds.