Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

Commit

Permalink
Mark java-class-imports-folding extension obsolete
Browse files Browse the repository at this point in the history
Extension is obsolete with redhat-developer/vscode-java#2133 resolved.
  • Loading branch information
baincd committed Nov 12, 2022
1 parent f4a5995 commit c52b48c
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 4 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.99.0] - 2022-11-12
### Changed
- Show warning message if installed version of Java extension version already provides this functionality
- Change name, readme of extension to reflect it is now obsolete


## [1.0.1] - 2022-03-26
### Added
- Support for single-line comments within imports
Expand Down
9 changes: 8 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
# Java Class Imports Folding
# Java Class Imports Folding [OBSOLETE]

This extension is obsolete.

This extension was a workaround for [vscode-java#2133](https://github.com/redhat-developer/vscode-java/issues/2133), which is fixed in [Language Support for Java(TM) by Red Hat v1.12](https://github.com/redhat-developer/vscode-java/releases/tag/v1.12.0).

---
# Original README

Add folding for imports on Java class files.

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"publisher": "baincd",
"name": "java-class-imports-folding",
"displayName": "Java Class Imports Folding",
"description": "Add folding for imports on Java class files",
"version": "1.0.1",
"displayName": "Java Class Imports Folding [OBSOLETE]",
"description": "Add folding for imports on Java class files (obsolete - see README)",
"version": "1.99.0",
"repository": {
"url": "https://github.com/baincd/vscode-java-class-imports-folding"
},
Expand Down
25 changes: 25 additions & 0 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,33 @@ class DiffFoldingRangeProvider implements vscode.FoldingRangeProvider {


export function activate(context: vscode.ExtensionContext) {
if (!vscode.workspace.getConfiguration().get<boolean>("java-class-imports-folding.disableJavaExtensionVersionCheck")) {
javaExtVersionCheck();
}

context.subscriptions.push(
vscode.languages.registerFoldingRangeProvider(
{language: "java", pattern: "**/*.class"}, new DiffFoldingRangeProvider()));

}
function javaExtVersionCheck() {
const javaExtFullVer = vscode.extensions.getExtension("redhat.java")?.packageJSON?.version as string;
if (javaExtFullVer) {
const [, major, minor] = javaExtFullVer.match(/^(\d+)\.(\d+)\./) || ["0.0", "0", "0"];
if (+major > 1 || +major == 1 && +minor >= 12) {
const MORE_INFO_BTN = "More Info";
const VIEW_EXT_SIDEBAR_BTN = "View in Extension Side Bar";

vscode.window.showWarningMessage(
"The extension \"Java Class Imports Folding\" is obsolete and can be uninstalled.",
VIEW_EXT_SIDEBAR_BTN, MORE_INFO_BTN
).then(selection => {
switch (selection) {
case MORE_INFO_BTN: vscode.commands.executeCommand('vscode.open', vscode.Uri.parse('https://github.com/baincd/vscode-java-class-imports-folding/blob/main/README.md')); break;
case VIEW_EXT_SIDEBAR_BTN: vscode.commands.executeCommand("workbench.extensions.search", "baincd.java-class-imports-folding"); break;
}
});
}
}
}

0 comments on commit c52b48c

Please sign in to comment.