Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retweets of tweets with quoted tweet and image only show image of quoted tweet #681

Closed
elya5 opened this issue Feb 26, 2017 · 3 comments
Closed

Comments

@elya5
Copy link

elya5 commented Feb 26, 2017

Here is an example with pictures

The retweet in my timeline:
retweet in timeline

The retweet after I click on it:
enlarged retweet

The original tweet in the users profile:
original

It would be nice to have an indication of the other image in the first picture.

@IBBoard
Copy link
Contributor

IBBoard commented Mar 13, 2017

I've not checked how it looked when you opened a single tweet, but is my pull request at #631 what you need? It looks like there's been enough changes that the pull request broke, but I'm still running the patch so I can re-apply and re-request.

baedert added a commit that referenced this issue Apr 1, 2017
baedert added a commit that referenced this issue Apr 1, 2017
@baedert
Copy link
Owner

baedert commented Apr 4, 2017

#631 is about sending them, this is just about displaying them. The rule is basically "a quote tweet can never have media attached, so if they do, ignore the quote tweet and show the media instead". It's pretty hard to find a tweet like this, and I guess I can't expect testing here so I'm going to close this until someone tells me they still have that problem or b495709 introduced a regression.

@baedert baedert closed this as completed Apr 4, 2017
@IBBoard
Copy link
Contributor

IBBoard commented Apr 4, 2017

Ah, yes, I misread it and saw similarities with the screenshots I'd posted. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants