Get data for [Discord] badges via OVH server proxies #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
paulmelnikow
previously approved these changes
Apr 27, 2020
services/discord/discord.service.js
Outdated
| @@ -62,6 +67,11 @@ module.exports = class Discord extends BaseJsonService { | |||
| } | |||
| } | |||
|
|
|||
| constructor(context, config) { | |||
| super(context, config) | |||
| this._runningOnHeroku = config.shieldsProductionHerokuHacks | |||
There was a problem hiding this comment.
Should we sync up these names? e.g. use shieldsProductionHerokuHacks for the instance var?
There was a problem hiding this comment.
yeah, missed that one somehow. updating now
|
Thanks for addressing this, Caleb! |
paulmelnikow
approved these changes
Apr 27, 2020
3 tasks
|
👀 thank you for this! |
This was referenced Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's more details on the underlying issue in our Discord channels, but for a tl;dr..
Discord throttles calls to their API, and they'd whitelisted our 3 OVH servers previously to allow us to get the requisite data. When we routed img.shields.io traffic over to our Heroku environment we lost that whitelisting and our badge servers (on Heroku) hit the rate limits pretty quickly resulting in
invalidfor all our Discord badges.This is a temporary fix to get the Discord badges working by having our Heroku-based badge servers use the OVH servers as a proxy to get the Discord data.