-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crates.io recent downloads badge (fixes #4186), run [Crates] #4187
Merged
calebcartwright
merged 4 commits into
badges:master
from
17cupsofcoffee:recent-crate-downloads
Oct 17, 2019
Merged
Add Crates.io recent downloads badge (fixes #4186), run [Crates] #4187
calebcartwright
merged 4 commits into
badges:master
from
17cupsofcoffee:recent-crate-downloads
Oct 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
calebcartwright
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
No problem, thank you for the helpful review comments 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
/crates/dr/:crate
(r for recent), as this seemed consistent with the existing routes in that namespace./d/:crate/:version
out of the examples, because it does the same thing as/dt/:crate/:version
and the latter makes more sense to me. The URL still works, though.:variant
- this seems to play nicer with the modal editor.Hopefully this is okay, first time contributing :)